From owner-cvs-all@FreeBSD.ORG  Tue Nov 28 16:07:32 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1CED016A416;
	Tue, 28 Nov 2006 16:07:32 +0000 (UTC)
	(envelope-from ru@rambler-co.ru)
Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DE71E43CA6;
	Tue, 28 Nov 2006 16:07:27 +0000 (GMT)
	(envelope-from ru@rambler-co.ru)
Received: from relay0.rambler.ru (localhost [127.0.0.1])
	by relay0.rambler.ru (Postfix) with ESMTP id D8D286116;
	Tue, 28 Nov 2006 19:07:29 +0300 (MSK)
Received: from edoofus.park.rambler.ru (unknown [81.19.65.108])
	by relay0.rambler.ru (Postfix) with ESMTP id B2EA9610C;
	Tue, 28 Nov 2006 19:07:29 +0300 (MSK)
Received: (from ru@localhost)
	by edoofus.park.rambler.ru (8.13.8/8.13.8) id kASG7Tad000845;
	Tue, 28 Nov 2006 19:07:29 +0300 (MSK) (envelope-from ru)
Date: Tue, 28 Nov 2006 19:07:29 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: "Greg 'groggy' Lehey" <grog@FreeBSD.org>
Message-ID: <20061128160729.GA761@rambler-co.ru>
References: <200611261903.kAQJ3KPp013911@repoman.freebsd.org>
	<20061127130323.GC77085@comp.chem.msu.su>
	<20061127223644.GV42090@wantadilla.lemis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU"
Content-Disposition: inline
In-Reply-To: <20061127223644.GV42090@wantadilla.lemis.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-Virus-Scanned: No virus found
Cc: Yar Tikhiy <yar@comp.chem.msu.su>, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, Florent Thoumie <flz@FreeBSD.org>, cvs-src@FreeBSD.org
Subject: Re: Style strangenesses (was: cvs commit: src/etc rc.subr)
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2006 16:07:32 -0000


--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 28, 2006 at 09:06:44AM +1030, Greg 'groggy' Lehey wrote:
> On Monday, 27 November 2006 at 16:03:24 +0300, Yar Tikhiy wrote:
> > By the way, now the output follows the NetBSD rc.conf style:
> >
> > # $foo_enable
> > foo_enable=3DYES
> >
> > Could it be changed even further to match our own rc.conf style?
> > I.e.:
> >
> > # $foo_enable
> > foo_enable=3D"YES"
>=20
> Can somebody justify this style to me?  It seems unnecessarily
> confusing, like Microsoft mail headers with
>=20
>   To: "'Fred Bloggs'" <fred@nowhere.com>
>=20
> I'm left with the feeling of sloppiness.
>=20
Quotes are needed if a value has spaces.  Quotes around values
without spaces aren't necessary but nice for uniformity.

That said, I don't normally use quotes in /boot/loader.conf.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--EeQfGwPcQSOJBaQU
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFbF7BqRfpzJluFF4RAvLlAJ0b4vJK1cUy+8jSJj6PR9p1+ILvSwCgg7fb
SpSZ+eIRmm+Pclx2CBxH8vc=
=NRZ7
-----END PGP SIGNATURE-----

--EeQfGwPcQSOJBaQU--