From owner-freebsd-fs@FreeBSD.ORG Sun Oct 7 09:34:14 2012 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48A121065670; Sun, 7 Oct 2012 09:34:14 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 4E8CD8FC0C; Sun, 7 Oct 2012 09:34:12 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA13438; Sun, 07 Oct 2012 12:34:11 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1TKnFT-0007yG-6X; Sun, 07 Oct 2012 12:34:11 +0300 Message-ID: <50714C91.4080407@FreeBSD.org> Date: Sun, 07 Oct 2012 12:34:09 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120913 Thunderbird/15.0.1 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <50713582.9040600@FreeBSD.org> <20121007092037.GB28611@garage.freebsd.pl> In-Reply-To: <20121007092037.GB28611@garage.freebsd.pl> X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "freebsd-fs@freebsd.org" Subject: Re: zfs_remove: delete_now case X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 09:34:14 -0000 on 07/10/2012 12:20 Pawel Jakub Dawidek said the following: > I'm fully aware of this code path being dead on FreeBSD. It is left there > only to minimize diff against vendor, so I'd prefer not to remove it. > Surrounding the code with '#ifdef sun' or similar is ok, I think. Ah, very good! It wasn't just clear from the code. I'll try to make the ifdef patch. -- Andriy Gapon