From owner-cvs-all Fri Dec 4 12:12:01 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA14890 for cvs-all-outgoing; Fri, 4 Dec 1998 12:09:57 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA14885; Fri, 4 Dec 1998 12:09:55 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.1/8.9.1) id MAA17142; Fri, 4 Dec 1998 12:09:37 -0800 (PST) (envelope-from dillon) Date: Fri, 4 Dec 1998 12:09:37 -0800 (PST) From: Matthew Dillon Message-Id: <199812042009.MAA17142@apollo.backplane.com> To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h References: <199812040349.TAA22636@freefall.freebsd.org> <19981204070811.A40154@nagual.pp.ru> <19981204071357.A41880@nagual.pp.ru> <199812040427.UAA03604@apollo.backplane.com> <19981204113427.A19232@nagual.pp.ru> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk : :On Thu, Dec 03, 1998 at 08:27:55PM -0800, Matthew Dillon wrote: :> Due to the extern badport_bandlim() I have to keep the #include in :> icmp_var.h ... but it isn't that bad, only three kernel files depend :> on icmp_var.h. I agree that doing the #include'ing in the two C files :> is cleaner, but what to do about the extern then ? : :Even in this variant you can safely remove opt_....h from icmp_var.h and :include it only into really affected *.c files instead (before :icmp_var.h). For kernel files which not needs this stuff but include :icmp_var.h even badport_...() prototype will be not picked which is good. : :-- :Andrey A. Chernov :http://www.nagual.pp.ru/~ache/ :MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y Ok, you mean keep the double #ifdef's at the end and the extern in the middle, but remove the opt #include and instead include the opt #include in the C files that require it prior to including icmp_var.h ?? That sounds reasonable. If I keep badport_bandlim() in ip_icmp.c, I definitely want to keep the extern either in icmp_var.h or in ip_icmp.h -Matt Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. (Please include original email in any response) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message