From owner-svn-src-head@FreeBSD.ORG Wed Sep 1 22:17:07 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8477610656B1; Wed, 1 Sep 2010 22:17:07 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 93AD88FC21; Wed, 1 Sep 2010 22:17:06 +0000 (UTC) Received: by ewy4 with SMTP id 4so5182436ewy.13 for ; Wed, 01 Sep 2010 15:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=xEps3BITXlBjOde8sDnD2So3Uc+ee5hKmN9YJ66YYVU=; b=ayn8OQs4xllm9I069F+7UFq4uv3teH7ErP8afgglju/cgctmWyVGteE+hblY4DSqf+ 2fc8qzPo5TOaUwHnMqB1GSC31nF7VHQaKi3dQfc5MmZjL86uXLwoO1rqxKyZz08rvSsQ GvhepwlbzhrgYXxpf+vBWBViDwQW8woE5JEHo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=sGAS4erfIE4ITYTwnAEDvSSDhjGbCfuXqHTxeJB2Eb6EG+ds28w5cLb5tASjnV8ib6 lkw/65O9MRAvvinjNcxDz54vTobs3MIdjHMaXv0AYD5TbzbYrf+jk7pCTFCDGyESCZnt nmnnySxBZRY+EwHNieONhKt/lxCjJN/tdwjvY= MIME-Version: 1.0 Received: by 10.213.7.7 with SMTP id b7mr12249961ebb.30.1283379425574; Wed, 01 Sep 2010 15:17:05 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.213.30.13 with HTTP; Wed, 1 Sep 2010 15:17:05 -0700 (PDT) In-Reply-To: <201009011731.12499.jhb@freebsd.org> References: <201009012032.o81KWmu5080032@svn.freebsd.org> <201009011731.12499.jhb@freebsd.org> Date: Wed, 1 Sep 2010 15:17:05 -0700 X-Google-Sender-Auth: wezK0s7SCA02Q2aXLLPPdg4EJjI Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212115 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2010 22:17:07 -0000 On Wed, Sep 1, 2010 at 2:31 PM, John Baldwin wrote: > On Wednesday, September 01, 2010 4:32:48 pm Matthew D Fleming wrote: >> Author: mdf >> Date: Wed Sep =A01 20:32:47 2010 >> New Revision: 212115 >> URL: http://svn.freebsd.org/changeset/base/212115 >> >> Log: >> =A0 Fix a bug with sched_affinity() where it checks td_pinned of another >> =A0 thread in a racy manner, which can lead to attempting to migrate a >> =A0 thread that is pinned to a CPU. =A0Instead, have sched_switch() dete= rmine >> =A0 which CPU a thread should run on if the current one is not allowed. >> >> =A0 KASSERT in sched_bind() that the thread is not yet pinned to a CPU. >> >> =A0 KASSERT in sched_switch() that only migratable threads or those movi= ng >> =A0 due to a sched_bind() are changing CPUs. >> >> =A0 sched_affinity code came from jhb@. >> >> =A0 MFC after: =A02 weeks > > Cool, I guess this fixed it in your tests then? Yes, the stress case I pointed out in the earlier thread ran for quite a few minutes before I killed it. Previously it would crash (with the added assert) in a few seconds. Thanks, matthew