From owner-freebsd-bugs@freebsd.org Fri Jul 28 03:57:55 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1E86DBCCED for ; Fri, 28 Jul 2017 03:57:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7738C723AA for ; Fri, 28 Jul 2017 03:57:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6S3vtrw010559 for ; Fri, 28 Jul 2017 03:57:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221059] release: scripts/mk-vmimage.sh does not fail on error Date: Fri, 28 Jul 2017 03:57:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: xmj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2017 03:57:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221059 Bug ID: 221059 Summary: release: scripts/mk-vmimage.sh does not fail on error Product: Base System Version: 10.3-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: misc Assignee: freebsd-bugs@FreeBSD.org Reporter: xmj@FreeBSD.org I'm currently trying to build AMI images, and I've noticed that one of the components of release behaves interestingly: During `make ec2ami` (more specifically, the cw-ec2 target) Makefile calls = out to scripts/mk-vmimage.sh. This script in turn sources its functions from tools/vmimage.subr. However, if for instance an error is obtained during the `vm_copy_base` pha= se, the script will continue as if nothing happens, and even end with a return value of 0. In my case, while trying to copy the "old" image's contents to the "new" im= age, the file-backed memorydisk was set to 5000M (too small for the packages I a= dded in). No step in mk-vmimage.sh will actually fail -- especially not the `vm_copy_base` step -- and the new system will end up missing arbitrary fil= es. Steps to reproduce: 1. in ${EC2CONF}, Set a VMSIZE that is too small to host the base system and all extra packages. 2. make WITH_CLOUDWARE=3Dyes [...] ec2ami --=20 You are receiving this mail because: You are the assignee for the bug.=