From owner-cvs-src@FreeBSD.ORG Fri Jan 27 03:02:28 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C1BA16A422; Fri, 27 Jan 2006 03:02:28 +0000 (GMT) (envelope-from jasone@FreeBSD.ORG) Received: from lh.synack.net (lh.synack.net [204.152.188.37]) by mx1.FreeBSD.org (Postfix) with ESMTP id B27BA43D46; Fri, 27 Jan 2006 03:02:27 +0000 (GMT) (envelope-from jasone@FreeBSD.ORG) Received: by lh.synack.net (Postfix, from userid 100) id 4B8E85E48EB; Thu, 26 Jan 2006 19:02:26 -0800 (PST) Received: from [192.168.168.203] (moscow-cuda-gen2-68-64-60-20.losaca.adelphia.net [68.64.60.20]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lh.synack.net (Postfix) with ESMTP id 65C735E48D1; Thu, 26 Jan 2006 19:02:21 -0800 (PST) In-Reply-To: <20060127025150.GA57825@nagual.pp.ru> References: <200601270236.k0R2ai2x067283@repoman.freebsd.org> <20060127025150.GA57825@nagual.pp.ru> Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> Content-Transfer-Encoding: 7bit From: Jason Evans Date: Thu, 26 Jan 2006 19:02:17 -0800 To: Andrey Chernov X-Mailer: Apple Mail (2.746.2) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on lh.synack.net X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2006 03:02:28 -0000 On Jan 26, 2006, at 6:51 PM, Andrey Chernov wrote: > I worry about my system performance. Could you please make all > statistics > and debug code conditional, debending on some flags which could be > set as > malloc options? Even in case this is a test period now, some people > perhaps don't want some tests. It is much easy to turn some tests > off via > malloc options than to comment out manually corresponding malloc.c > defines > after each cvsup. Unfortunately, run-time checks for the debugging features are expensive, since the debugging code is scattered throughout malloc.c. This pretty much mandates compile-time configuration, for performance reasons. I can disable statistics and debugging, if there's a general consensus to do so. How much performance difference is the debug/ stats code making for you? I've only been disabling debug/stats for benchmarking purposes, so I don't have a good feel for how much it impacts overall system performance. Thanks, Jason