From owner-freebsd-net@freebsd.org Tue Mar 23 18:28:39 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 934895B76D3 for ; Tue, 23 Mar 2021 18:28:39 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4fyH3K3wz3l1B; Tue, 23 Mar 2021 18:28:39 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2a02:8109:1140:c3d:3063:f2ec:8e4c:4b] (unknown [IPv6:2a02:8109:1140:c3d:3063:f2ec:8e4c:4b]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 6CF0C702688E6; Tue, 23 Mar 2021 19:28:28 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: tcp-testsuite into src? From: tuexen@freebsd.org In-Reply-To: Date: Tue, 23 Mar 2021 19:28:27 +0100 Cc: FreeBSD Net , rscheff@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <8F452EAE-9A63-4359-A16A-9FA0A369B981@freebsd.org> References: To: Kevin Bowling X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4F4fyH3K3wz3l1B X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 18:28:39 -0000 > On 23. Mar 2021, at 02:31, Kevin Bowling wrote: > > Hi, > > I was talking with gnn and kevans on IRC about the tcp testsuite > (https://github.com/freebsd-net/tcp-testsuite). > > Currently we maintain this in ports, although the way the port is set > up doesn't make a lot of sense because the tests are stack specific > and we don't account for different FreeBSD versions let alone vendor Just to be clear: * The tests only work with FreeBSD head/master/main. * The current tests should work with the freebsd, the rack and bbr stack. However, the tests sometimes need updates to reflect code changes. > trees. It seems reasonable to me to pull the tests themselves (i.e. > https://github.com/freebsd-net/tcp-testsuite) into src where they can > follow along with the tree they are running on, and provide vendors a > natural point of extension. I'm happy to have them in the src repo. That way it would be possible to also support stable/13 and (possibly) stable/12. > > /usr/tests has some existing examples of relying on out of tree > binaries to run so I am not convinced we need to import packetdrill > itself but I don't have a strong preference. tuexen, do you have any > preference? No. Just as a note. There do also exist SCTP tests and I had sometime ago some UDP lite tests. So we might want to have a directory layout supporting multiple protocols. Best regards Michael > > Regards, > Kevin