From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 503EFDCF71; Tue, 3 Sep 2019 14:06:48 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zq5RK3z4Pw2; Tue, 3 Sep 2019 14:06:47 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 845901ABB8; Tue, 3 Sep 2019 14:06:17 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id D4DE319F15; Fri, 12 Apr 2019 20:11:09 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BDF08AB8A; Fri, 12 Apr 2019 20:11:09 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id E879419EBA; Fri, 12 Apr 2019 20:11:08 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id DD59119EB8 for ; Fri, 12 Apr 2019 20:11:08 +0000 (UTC) (envelope-from tychon@freebsd.org) Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95FDE8AB84; Fri, 12 Apr 2019 20:11:08 +0000 (UTC) (envelope-from tychon@freebsd.org) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D5B7A133881; Fri, 12 Apr 2019 16:11:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=content-type :mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=sasl; bh= F378u8Cgqa5KYo5W60fhER7FXQw=; b=lZTjewozXKWLSquspR47B1gCVJWJLeHC z9slRTENZfIVM6iU5laCsxRFdK7Be/ltVcHkPHBJVORzrb4bf9xZWJb3+2aJtpnm zboEy2AWKVBZEldcGl6iwMy9oxsy940g/lJosbCb5kgZbdNpmsNAKmS76LDT9e48 g2nbGrU5ykA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C9AF9133880; Fri, 12 Apr 2019 16:11:01 -0400 (EDT) Received: from [10.0.1.195] (unknown [146.115.68.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id DF13613387D; Fri, 12 Apr 2019 16:11:00 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r346150 - head/sys/vm From: Tycho Nightingale In-Reply-To: <94A39E35-A8E0-42A4-8467-096D4AAD0F89@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4DA68C34-12A0-4E62-B868-F7BE10CB06BD@freebsd.org> References: <201904121246.x3CCkP2m027680@repo.freebsd.org> <94A39E35-A8E0-42A4-8467-096D4AAD0F89@gmail.com> To: Enji Cooper X-Mailer: Apple Mail (2.3445.9.1) X-Pobox-Relay-ID: 178FEA8A-5D5F-11E9-9CC3-1646B3964D18-09779102!pb-smtp1.pobox.com Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 3BDF08AB8A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:35 -0000 X-Original-Date: Fri, 12 Apr 2019 16:10:59 -0400 X-List-Received-Date: Tue, 03 Sep 2019 14:07:35 -0000 > On Apr 12, 2019, at 12:43 PM, Enji Cooper = wrote: >=20 >=20 >> On Apr 12, 2019, at 5:46 AM, Tycho Nightingale = wrote: >>=20 >> Author: tychon >> Date: Fri Apr 12 12:46:25 2019 >> New Revision: 346150 >> URL: https://svnweb.freebsd.org/changeset/base/346150 >>=20 >> Log: >> for a cache-only zone the destructor tries to destroy a non-existent = keg >>=20 >> Reviewed by: markj >> Sponsored by: Dell EMC Isilon >> Differential Revision: https://reviews.freebsd.org/D19835 >=20 >=20 > Hi Tycho! > Is the goal of this change to prevent a panic (with an = INVARIANTS kernel)? > Thank you! > -Enji Hi, The goal of this change is to fix a regression introduced in r343026. = It does cause a panic independent of INVARIANTS. Fortunately there = isn=E2=80=99t currently any in-tree code which triggers the panic. It = does however show up when running with the patch under review in D19845. Tycho