From owner-p4-projects@FreeBSD.ORG  Wed Feb 20 01:13:34 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 21F9716A409; Wed, 20 Feb 2008 01:13:34 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A852316A401;
	Wed, 20 Feb 2008 01:13:33 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 7111713C45B;
	Wed, 20 Feb 2008 01:13:33 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m1K1AZai053627;
	Tue, 19 Feb 2008 18:10:35 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 19 Feb 2008 18:10:53 -0700 (MST)
Message-Id: <20080219.181053.824013453.imp@bsdimp.com>
To: sam@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200802192338.m1JNcKvG037641@repoman.freebsd.org>
References: <200802192338.m1JNcKvG037641@repoman.freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@FreeBSD.org
Subject: Re: PERFORCE change 135760 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2008 01:13:34 -0000

	Suppress the aggressive inline of gcc; there is no obvious
	benefit to doing it and the downsides are significant.  Once
	I can nagivate the maze of twisty #ifdefs in cdefs.h I'll
	add __noinline where it belongs.

Maybe the following is sufficient?

Index: cdefs.h
===================================================================
RCS file: /cache/ncvs/src/sys/sys/cdefs.h,v
retrieving revision 1.94
diff -u -r1.94 cdefs.h
--- cdefs.h	9 Dec 2007 21:00:36 -0000	1.94
+++ cdefs.h	20 Feb 2008 01:09:57 -0000
@@ -241,6 +241,12 @@
 #define	__gnu89_inline
 #endif
 
+#if __GNUC_PREREQ__(3, 1)
+#define __noinline	__attribute__((__noinline__))
+#else
+#define __noinline
+#endif
+
 #if __GNUC_PREREQ__(3, 3)
 #define __nonnull(x)	__attribute__((__nonnull__(x)))
 #else