From owner-svn-src-head@freebsd.org Wed May 3 19:32:27 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05445D5824E; Wed, 3 May 2017 19:32:27 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x22a.google.com (mail-yw0-x22a.google.com [IPv6:2607:f8b0:4002:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B7F0F1179; Wed, 3 May 2017 19:32:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x22a.google.com with SMTP id 203so90270342ywe.0; Wed, 03 May 2017 12:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=FCE5sXsEsiZq3aYqJIfY/LwXUUNTk1SQRMg9nib3zuM=; b=Kl3oO3zSZGBPvajZOmpZvpf6s3QcuXzRwjMahPer+27ZAmU+R4rX5uyKZNMZ0iNVwN 82pn6cHmsaCT5pUrYoyE6gbh/fww6mP8CJjYcaXQ90urKx+jsCFTRyH8A02VbEF7/1E7 3eU/OwcVSjtnphBfQNV72HbXSdkjpeoqJHtf5Nf+sHqSk5EaqA/hzzMR+KrNOuPFvXMS S71DcA4HdgrmbrzJIj1vTb6AXcohxlBpXnpdXdkLhNKvR+BnZKPmm6wNyvg/X5zQ8FEt O5Nivlg+onEXJoTmu3+oE2K8jlAqFFz/+hP4BJ0K90rRfm6LFqKJoAfjVtiuFHuJHfEJ YAnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=FCE5sXsEsiZq3aYqJIfY/LwXUUNTk1SQRMg9nib3zuM=; b=oa7AwdUdzN2uLUysi0rBObauMAeRKxlv4kSkDonU8hmhaLXk1KwgXOcsrrjyr4RxWu gNaBQe35tBczGIh8dCbZaxHQPQsSI2QS0K0yBBQX86YEQ98n4yMArby2M5+txQK2y9Jj lUZruvI3EHKzmTJDDq/NO4WoizVkdIOPsGOdK1g7mygR7rNT7DgIbPMar/eYBrzX3hkI /+V00318n4fxcohhPogr6jS4VhHVh43LlgSVBDrhc1w8yrXY95HuEgUUz0GhOgA4kZZD O0QEmbDqJd03Xd0Nxd5Et4mNaUGqbPF7lcetJnUVuBUa/EFeuGWMtEdQEuVR2aifjrN7 qp/A== X-Gm-Message-State: AN3rC/501uFR4Z0O1PdHe8almVAR7Mc5Vv6t/wQTKYOoqjqLHAZu2tdI lzvmgCxQqbABfrWEejkFU3YXJH5cVA== X-Received: by 10.129.52.75 with SMTP id b72mr3848028ywa.271.1493839945922; Wed, 03 May 2017 12:32:25 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.20.214 with HTTP; Wed, 3 May 2017 12:32:25 -0700 (PDT) In-Reply-To: <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> References: <201705031721.v43HL2vS071819@repo.freebsd.org> <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> From: Alan Somers Date: Wed, 3 May 2017 13:32:25 -0600 X-Google-Sender-Auth: aLmtyeQ7ttA8CUdvaO7RfBQHPQk Message-ID: Subject: Re: svn commit: r317755 - head/sbin/ifconfig To: Ngie Cooper Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 19:32:27 -0000 On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper wrote: > >> On May 3, 2017, at 10:21, Alan Somers wrote: >> >> Author: asomers >> Date: Wed May 3 17:21:01 2017 >> New Revision: 317755 >> URL: https://svnweb.freebsd.org/changeset/base/317755 >> >> Log: >> Various Coverity fixes in ifconfig(8) > > ... > >> * Mark usage() as _Noreturn (1305806, 1305750) > > ... > >> -static void usage(void); >> +static void usage(void) _Noreturn; > > Hi Alan, > Please use __dead2 instead to be consistent with legacy use of similar gcc attributes. > Thanks, > -Ngie Why not use _Noreturn? It's standardized by C11, so tools understand it better than __dead2. -Alan