From owner-cvs-src@FreeBSD.ORG Sun Oct 31 21:20:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2CEC16A4CE; Sun, 31 Oct 2004 21:20:46 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F49B43D2D; Sun, 31 Oct 2004 21:20:46 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id i9VLJ0EI028452; Sun, 31 Oct 2004 14:19:00 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 31 Oct 2004 14:19:00 -0700 (MST) Message-Id: <20041031.141900.36023096.imp@bsdimp.com> To: mjacob44@yahoo.com From: "M. Warner Losh" In-Reply-To: <20041031035037.59607.qmail@web21422.mail.yahoo.com> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: gibbs@scsiguy.com cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: bms@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 21:20:47 -0000 In message: <20041031035037.59607.qmail@web21422.mail.yahoo.com> Matthew Jacob writes: : Shouldn't an API for adding or removing ISR's be responsible for : handling just such a race condition? It does. After you've deregistered your interrupt, you are guaranteed that (a) it will never be called again and (b) no one is currently in that ISR. However, if you just turn off the interrupts in the hardware device, neither (a) nor (b) apply. Warner