From owner-svn-src-head@freebsd.org Thu Oct 15 20:21:17 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4672C446D06; Thu, 15 Oct 2020 20:21:17 +0000 (UTC) (envelope-from mhorne@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CC0zd19z6z40QM; Thu, 15 Oct 2020 20:21:17 +0000 (UTC) (envelope-from mhorne@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E709124CE7; Thu, 15 Oct 2020 20:21:16 +0000 (UTC) (envelope-from mhorne@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 09FKLGf2016518; Thu, 15 Oct 2020 20:21:16 GMT (envelope-from mhorne@FreeBSD.org) Received: (from mhorne@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 09FKLGsb016515; Thu, 15 Oct 2020 20:21:16 GMT (envelope-from mhorne@FreeBSD.org) Message-Id: <202010152021.09FKLGsb016515@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mhorne set sender to mhorne@FreeBSD.org using -f From: Mitchell Horne Date: Thu, 15 Oct 2020 20:21:16 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366737 - in head/sys: amd64/amd64 arm/arm arm64/arm64 riscv/riscv X-SVN-Group: head X-SVN-Commit-Author: mhorne X-SVN-Commit-Paths: in head/sys: amd64/amd64 arm/arm arm64/arm64 riscv/riscv X-SVN-Commit-Revision: 366737 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 20:21:17 -0000 Author: mhorne Date: Thu Oct 15 20:21:15 2020 New Revision: 366737 URL: https://svnweb.freebsd.org/changeset/base/366737 Log: Simplify preload_dump() condition Hiding this feature behind RB_VERBOSE is gratuitous. The tunable is enough to limit its use to only those who explicitly request it. Suggested by: kevans Modified: head/sys/amd64/amd64/machdep.c head/sys/arm/arm/machdep.c head/sys/arm64/arm64/machdep.c head/sys/riscv/riscv/machdep.c Modified: head/sys/amd64/amd64/machdep.c ============================================================================== --- head/sys/amd64/amd64/machdep.c Thu Oct 15 18:03:14 2020 (r366736) +++ head/sys/amd64/amd64/machdep.c Thu Oct 15 20:21:15 2020 (r366737) @@ -1859,8 +1859,7 @@ hammer_time(u_int64_t modulep, u_int64_t physfree) * output is required. If it's grossly incorrect the kernel will never * make it this far. */ - if ((boothowto & RB_VERBOSE) && - getenv_is_true("debug.dump_modinfo_at_boot")) + if (getenv_is_true("debug.dump_modinfo_at_boot")) preload_dump(); #ifdef DEV_ISA Modified: head/sys/arm/arm/machdep.c ============================================================================== --- head/sys/arm/arm/machdep.c Thu Oct 15 18:03:14 2020 (r366736) +++ head/sys/arm/arm/machdep.c Thu Oct 15 20:21:15 2020 (r366737) @@ -1032,8 +1032,7 @@ initarm(struct arm_boot_params *abp) * output is required. If it's grossly incorrect the kernel will never * make it this far. */ - if ((boothowto & RB_VERBOSE) && - getenv_is_true("debug.dump_modinfo_at_boot")) + if (getenv_is_true("debug.dump_modinfo_at_boot")) preload_dump(); env = kern_getenv("kernelname"); Modified: head/sys/arm64/arm64/machdep.c ============================================================================== --- head/sys/arm64/arm64/machdep.c Thu Oct 15 18:03:14 2020 (r366736) +++ head/sys/arm64/arm64/machdep.c Thu Oct 15 20:21:15 2020 (r366737) @@ -1247,8 +1247,7 @@ initarm(struct arm64_bootparams *abp) * output is required. If it's grossly incorrect the kernel will never * make it this far. */ - if ((boothowto & RB_VERBOSE) && - getenv_is_true("debug.dump_modinfo_at_boot")) + if (getenv_is_true("debug.dump_modinfo_at_boot")) preload_dump(); init_proc0(abp->kern_stack); Modified: head/sys/riscv/riscv/machdep.c ============================================================================== --- head/sys/riscv/riscv/machdep.c Thu Oct 15 18:03:14 2020 (r366736) +++ head/sys/riscv/riscv/machdep.c Thu Oct 15 20:21:15 2020 (r366737) @@ -954,8 +954,7 @@ initriscv(struct riscv_bootparams *rvbp) * output is required. If it's grossly incorrect the kernel will never * make it this far. */ - if ((boothowto & RB_VERBOSE) && - getenv_is_true("debug.dump_modinfo_at_boot")) + if (getenv_is_true("debug.dump_modinfo_at_boot")) preload_dump(); init_proc0(rvbp->kern_stack);