From owner-freebsd-geom@FreeBSD.ORG  Sat Sep 11 17:59:18 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 092F516A4CE
	for <freebsd-geom@freebsd.org>; Sat, 11 Sep 2004 17:59:18 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5DF8143D53
	for <freebsd-geom@freebsd.org>; Sat, 11 Sep 2004 17:59:17 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i8BHx71I027672;
	Sat, 11 Sep 2004 19:59:12 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Allan Fields <bsd@afields.ca>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 10 Sep 2004 12:37:07 EDT."
             <20040910163707.GL34157@afields.ca> 
Date: Sat, 11 Sep 2004 19:59:07 +0200
Message-ID: <27671.1094925547@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: DOT <dot@data.pl>
cc: freebsd-geom@freebsd.org
Subject: Re: Can't reattach gbde slice [testing] 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Sep 2004 17:59:18 -0000


can you try the two fixes I just committed to -current ?


In message <20040910163707.GL34157@afields.ca>, Allan Fields writes:
>On Wed, Sep 08, 2004 at 03:25:24PM +0200, Poul-Henning Kamp wrote:
>>
>> Here is one bugfix, but I'm not 100% sure it is what bites
>> you, but please test anyway.
>
>It doesn't resolve the master key sector overwrite bug, but otherwise
>works fine.  In my tests number_of_keys=4 works reliably even with
>raw slices, doesn't preclude scenario w/ beginning of slice being
>overwritten by other install/OS.
>
>The issue seems at some point (depending on master key location)
>w/ number_of_keys=1 the device eventually fills up enough to
>overwrite key sector(s): could be boundary condition.
>
>To try:
>- number_of_keys=2, number_of_keys=3
>- fist_sector=0+x, last_sector=N-x tests
>- debug: set some break points in bde when (offset == master key offset)
>(other tests:)
>- backup/restore key sectors, try fsck
>- non-ufs use of device should reproduce, verify
>
>> Poul-Henning
>>
>> phk@FreeBSD.ORG         | TCP/IP since RFC 956
>> FreeBSD committer       | BSD since 4.3-tahoe    
>> Never attribute to malice what can adequately be explained by incompetence.
>
>-- 
> Allan Fields, AFRSL - http://afields.ca
> 2D4F 6806 D307 0889 6125  C31D F745 0D72 39B4 5541
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.