From owner-freebsd-multimedia@FreeBSD.ORG Fri Aug 16 20:12:10 2013 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 92651839 for ; Fri, 16 Aug 2013 20:12:10 +0000 (UTC) (envelope-from nox@jelal.kn-bremen.de) Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116]) by mx1.freebsd.org (Postfix) with ESMTP id 4EFC52EB8 for ; Fri, 16 Aug 2013 20:12:10 +0000 (UTC) Received: by smtp.kn-bremen.de (Postfix, from userid 10) id 507FA1E007B9; Fri, 16 Aug 2013 22:12:09 +0200 (CEST) Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1]) by triton8.kn-bremen.de (8.14.5/8.14.4) with ESMTP id r7GKAseH023851; Fri, 16 Aug 2013 22:10:54 +0200 (CEST) (envelope-from nox@triton8.kn-bremen.de) Received: (from nox@localhost) by triton8.kn-bremen.de (8.14.5/8.14.3/Submit) id r7GKAsuS023850; Fri, 16 Aug 2013 22:10:54 +0200 (CEST) (envelope-from nox) From: Juergen Lock Date: Fri, 16 Aug 2013 22:10:54 +0200 To: Hans Petter Selasky Subject: Re: New version of webcamd [3.11.0.1] ready for testing Message-ID: <20130816201054.GA23829@triton8.kn-bremen.de> References: <51A10BD5.1050107@bitfrost.no> <20130816183810.GA16711@triton8.kn-bremen.de> <520E83F4.6010307@bitfrost.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <520E83F4.6010307@bitfrost.no> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "freebsd-multimedia@freebsd.org" , Juergen Lock , Srinivas Kandagatla X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2013 20:12:10 -0000 On Fri, Aug 16, 2013 at 09:56:36PM +0200, Hans Petter Selasky wrote: > Hi Srinivas, > > Can you submit the patch from Juergen? Thank you! > I already submitted it myself. Thanx, :) Juergen > > Ah indeed that is better, now technisat-usb2 works again, including > > it's remote. :) Here is the patch: > > > > --- media_tree/drivers/media/rc/rc-main.c.orig > > +++ media_tree/drivers/media/rc/rc-main.c > > @@ -707,7 +707,7 @@ int rc_open(struct rc_dev *rdev) > > return -EINVAL; > > > > mutex_lock(&rdev->lock); > > - if (!rdev->users++) > > + if (!rdev->users++ && rdev->open != NULL) > > rval = rdev->open(rdev); > > > > if (rval) > > @@ -731,7 +731,7 @@ void rc_close(struct rc_dev *rdev) > > if (rdev) { > > mutex_lock(&rdev->lock); > > > > - if (!--rdev->users) > > + if (!--rdev->users && rdev->close != NULL) > > rdev->close(rdev); > > > > mutex_unlock(&rdev->lock); > >> --HPS > >> > > And now I also tested rtl28xxu, af9015, af9035, ati_remote, mceusb, > > uvc, gspca and they also all worked as before. > > > > Thanx! > > Juergen > > I'll wait a bit for the patch to reach V4L GIT and then I'll roll > another tarball! > > Thanks Juergen! > > --HPS >