From owner-freebsd-isdn Mon Jan 10 15:12:32 2000 Delivered-To: freebsd-isdn@freebsd.org Received: from peedub.muc.de (peedub.muc.de [193.149.49.109]) by hub.freebsd.org (Postfix) with ESMTP id 53EC714F6D for ; Mon, 10 Jan 2000 15:12:25 -0800 (PST) (envelope-from garyj@peedub.muc.de) Received: from peedub.muc.de (localhost [127.0.0.1]) by peedub.muc.de (8.9.3/8.6.9) with ESMTP id XAA63204; Mon, 10 Jan 2000 23:48:37 +0100 (CET) Message-Id: <200001102248.XAA63204@peedub.muc.de> X-Mailer: exmh version 2.1.0 09/18/1999 To: jan@sparud.net (Jan Sparud) Cc: freebsd-isdn@FreeBSD.ORG Subject: Re: LCP loop problem fixed Reply-To: Gary Jennejohn In-reply-to: Your message of "Sun, 09 Jan 2000 18:21:50 +0100." <14456.50094.237265.228095@hinken.sparud.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 10 Jan 2000 23:48:37 +0100 From: Gary Jennejohn Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Jan Sparud writes: > >(Sorry for the length of this mail) > I think it's well worth the length, since you provide a good explanation of how you found the problem. >*** if_spppsubr.c Sat Jan 8 13:28:48 2000 >--- if_spppsubr.c.15 Sat Jan 8 13:20:54 2000 [snip] >! sp->lcp.timeout = 1 * hz; [snip] >--- 1828,1836 ---- [snip] >! sp->lcp.timeout = 3 * hz; [snip] this seems to be very hardware dependent. I'm using -current where the timeout is set to 3*hz and I've *never* experienced a problem using sppp to my ISP. [lots snipped] This is great stuff and I'm glad you took the time to find and fix the (apparent) bug. I only have one comment - where you define HZ as 100. This information can be obtained from the kernel using sysctl. There's a good example in /usr/src/lib/libc/gmon/gmon.c where clockinfo is used. It would be nice to get this into the CVS tree, but I'm not sure that will be possible :( --- Gary Jennejohn / garyj@muc.de garyj@fkr.cpqcorp.net gj@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message