From owner-freebsd-hackers@FreeBSD.ORG Wed Oct 8 14:42:32 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5916876F for ; Wed, 8 Oct 2014 14:42:32 +0000 (UTC) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0091.outbound.protection.outlook.com [65.55.169.91]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 03CE19DC for ; Wed, 8 Oct 2014 14:42:30 +0000 (UTC) Received: from DM2PR0801MB0944.namprd08.prod.outlook.com (25.160.131.27) by DM2PR0801MB0943.namprd08.prod.outlook.com (25.160.131.26) with Microsoft SMTP Server (TLS) id 15.0.1039.15; Wed, 8 Oct 2014 14:42:22 +0000 Received: from DM2PR0801MB0944.namprd08.prod.outlook.com ([25.160.131.27]) by DM2PR0801MB0944.namprd08.prod.outlook.com ([25.160.131.27]) with mapi id 15.00.1039.011; Wed, 8 Oct 2014 14:42:22 +0000 From: "Pokala, Ravi" To: "freebsd-hackers@freebsd.org" Subject: Re: Seeking reviewers for patch; PR 193873 Thread-Topic: Seeking reviewers for patch; PR 193873 Thread-Index: AQHP4wYRwsbUBpMNTk6xd1JtizXBKg== Date: Wed, 8 Oct 2014 14:42:22 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.4.140807 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [24.6.178.251] x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0801MB0943; x-forefront-prvs: 0358535363 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(13464003)(52314003)(164054003)(53754006)(189002)(51704005)(199003)(87936001)(46102003)(19580405001)(97736003)(50986999)(2351001)(31966008)(110136001)(77096002)(2656002)(107886001)(19580395003)(99286002)(76482002)(106116001)(54356999)(80022003)(85852003)(15975445006)(95666004)(83506001)(85306004)(66066001)(512954002)(64706001)(21056001)(92726001)(4396001)(20776003)(120916001)(92566001)(99396003)(106356001)(107046002)(86362001)(101416001)(105586002)(122556002)(40100002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0801MB0943; H:DM2PR0801MB0944.namprd08.prod.outlook.com; FPR:; MLV:sfv; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: panasas.com X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Oct 2014 14:42:32 -0000 -----Original Message----- >Date: Mon, 6 Oct 2014 14:20:12 +0000 >From: "Meyer, Conrad" >To: "freebsd-hackers@freebsd.org" >Subject: Seeking reviewers for patch; PR 193873 >Message-ID: > >Content-Type: text/plain; charset=3D"us-ascii" > >Hi all, > >The patch[0] dedupes dumpsys() somewhat, leaving MD-specific support code >for a few things (map/unmap a region, flush CPU writeback cache, iterate >physmem segments). > >jhibbits@ is taking a look, but he'd like another pair of eyeballs. The >more, the merrier! If someone could throw the latest patch up in >phabricator for discussion, that would be awesome. > >I'll also need someone willing to commit it, I'm not a committer. > >Questions/concerns/feedback? Hi Conrad, As mentioned in another thread ([1], [2]), I'm looking at dumping on systems w/ AF-4Kn drives (on a fairly old version of FreeBSD). Unfortunately, I'm not at all familiar w/ the process. I'm going to pick at it a few more days, but will probably end up having to punt and dumpsys onto a 512n or AF-512e device. But, since you are refactoring all this code in -CURRENT anyway, I think it would be awesome if you could look to the future and make it work w/o assuming that dump device block size is DEV_BSIZE; it would be better to use the sector size, as returned (for example) by ioctl(DIOCGSECTORSIZE). That won't help me now, but hopefully it will help everyone in the future. Thanks, Ravi [1]:=20 https://lists.freebsd.org/pipermail/freebsd-hackers/2014-September/046164.h tml [2]:=20 https://lists.freebsd.org/pipermail/freebsd-hackers/2014-October/046181.htm l >Thanks, >Conrad > >[0]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D193873