From owner-svn-ports-head@freebsd.org  Mon Oct  9 16:24:25 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D86A6E3565F;
 Mon,  9 Oct 2017 16:24:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 74BD9657EF;
 Mon,  9 Oct 2017 16:24:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id D8B79D76E; Mon,  9 Oct 2017 16:23:42 +0000 (UTC)
Date: Mon, 9 Oct 2017 16:23:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Joe Marcus Clarke <marcus@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r451553 - in head/ports-mgmt/portlint: . src
Message-ID: <20171009162342.GA2723@FreeBSD.org>
References: <201710081758.v98HwqIe003342@repo.freebsd.org>
 <e577bff2-63cf-7411-74e1-f587e4dee31f@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e577bff2-63cf-7411-74e1-f587e4dee31f@FreeBSD.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Oct 2017 16:24:26 -0000

On Mon, Oct 09, 2017 at 06:07:00PM +0200, Mathieu Arnold wrote:
> Le 08/10/2017 ?? 19:58, Joe Marcus Clarke a ??crit :
> > New Revision: 451553
> > URL: https://svnweb.freebsd.org/changeset/ports/451553
> >
> > Log:
> >   Update to 2.17.13.
> >   
> >   * Do not complain about USE_GITHUB before USES [1]
> 
> This is wrong. USES= must always happen before any other USE_* variable.

Not really.  GitHub-related knobs are often grouped together and put
closer to the top because they are more related to obtaining the distfile
(think MASTER_SITES) rather than the configuring/building/etc. steps of
the software in question itself.

Technically there's nothing wrong with any order prior to .include's of
other Mk/* files, so this kind of grouping helps readability while not
affecting anything else.

./danfe