From owner-freebsd-current@FreeBSD.ORG Wed Sep 17 01:27:55 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B5C9F16A4B3 for ; Wed, 17 Sep 2003 01:27:55 -0700 (PDT) Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 25DE743FBD for ; Wed, 17 Sep 2003 01:27:54 -0700 (PDT) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de (cicely5.cicely.de [IPv6:3ffe:400:8d0:301:200:92ff:fe9b:20e7]) (authenticated bits=0) by srv1.cosmo-project.de (8.12.9/8.12.9) with ESMTP id h8H8Rj9H095319 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Wed, 17 Sep 2003 10:27:50 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [IPv6:3ffe:400:8d0:301::12]) by cicely5.cicely.de (8.12.9/8.12.9) with ESMTP id h8H8RhhF051757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Sep 2003 10:27:44 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.12.9/8.12.9) with ESMTP id h8H8RhrY099312; Wed, 17 Sep 2003 10:27:43 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.12.9/8.12.9/Submit) id h8H8RcvB099311; Wed, 17 Sep 2003 10:27:38 +0200 (CEST) Date: Wed, 17 Sep 2003 10:27:38 +0200 From: Bernd Walter To: Poul-Henning Kamp Message-ID: <20030917082738.GW26878@cicely12.cicely.de> References: <20030916102534.J2924@gamplex.bde.org> <24374.1063782444@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24374.1063782444@critter.freebsd.dk> X-Operating-System: FreeBSD cicely12.cicely.de 5.1-CURRENT alpha User-Agent: Mutt/1.5.4i cc: current@freebsd.org cc: Kris Kennaway Subject: Re: panic: Negative bio_offset (-15050100712783872) on bio 0xc7725d50 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: ticso@cicely.de List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2003 08:27:55 -0000 On Wed, Sep 17, 2003 at 09:07:24AM +0200, Poul-Henning Kamp wrote: > In message <20030916102534.J2924@gamplex.bde.org>, Bruce Evans writes: > > >This is either disk corruption or an ffs bug. ffs passes the garbage > >block number 0xffffe5441ae9720 to bread. GEOM then handles this austerely > >by panicing. Garbage block numbers, including negative ones, can possibly > >be created by applications seeking to preposterous offsets, so they should > >not be handled with panics. > > They most certainly should! If the range checking in any filesystem > is not able to catch these cases I insist that GEOM do so with a panic. What is wrong with returning an IO error? I always hated panics because of filesystem corruptions. An alternative would be to just bring that filesystem down. Its easy to panic a whole system with a bogus filesystem on a removeable media. -- B.Walter BWCT http://www.bwct.de ticso@bwct.de info@bwct.de