From owner-freebsd-fs@FreeBSD.ORG Wed May 26 11:49:30 2010 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7553F106566C for ; Wed, 26 May 2010 11:49:30 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id B7A598FC08 for ; Wed, 26 May 2010 11:49:29 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 0029245CA0; Wed, 26 May 2010 13:49:26 +0200 (CEST) Received: from localhost (pdawidek.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 243A64569A; Wed, 26 May 2010 13:49:22 +0200 (CEST) Date: Wed, 26 May 2010 13:49:09 +0200 From: Pawel Jakub Dawidek To: Andriy Gapon Message-ID: <20100526114909.GC3339@garage.freebsd.pl> References: <4BFA9AEC.1070608@jrv.org> <4BFB884A.3010804@jrv.org> <20100525192721.GE1659@garage.freebsd.pl> <4BFD02DC.1050203@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NKoe5XOeduwbEQHU" Content-Disposition: inline In-Reply-To: <4BFD02DC.1050203@icyb.net.ua> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@FreeBSD.org Subject: Re: ZFS panic: wrong length 131072 for sectorsize 2352 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2010 11:49:30 -0000 --NKoe5XOeduwbEQHU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 26, 2010 at 02:15:40PM +0300, Andriy Gapon wrote: > on 25/05/2010 22:27 Pawel Jakub Dawidek said the following: > > On Tue, May 25, 2010 at 03:20:26AM -0500, James R. Van Artsdalen wrote: > >> On 5/24/2010 10:27 AM, James R. Van Artsdalen wrote: > >>> panic: wrong length 131072 for sectorsize 2352 > >> This fixes the bug. > >=20 > > I don't think so:) size should be properly calculated at this point and > > should be multiple of sectorsize. The problem is that vdev_geom_io() > > splits request into MAXPHYS chunks if it is too big, which is wrong, > > because MAXPHYS doesn't have to be multiple of sectorsize. >=20 > But do we really want to support here sector sizes that are not power of = two? We can easly support them, so why not? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --NKoe5XOeduwbEQHU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkv9CrUACgkQForvXbEpPzQECQCcCGYQjHZ57QX5YEptEbbuom39 lf8Amwb9CelZEwMkx/1OP3bc9w2zRyp1 =IDm0 -----END PGP SIGNATURE----- --NKoe5XOeduwbEQHU--