From owner-svn-src-head@freebsd.org Thu Jan 26 03:55:23 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF282CC13BE; Thu, 26 Jan 2017 03:55:23 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 751C71EA9; Thu, 26 Jan 2017 03:55:23 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id Wb9WcuUqhsa1kWb9Xci28v; Wed, 25 Jan 2017 20:55:16 -0700 X-Authority-Analysis: v=2.2 cv=W+NIbVek c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=IgFoBzBjUZAA:10 a=JzwRw_2MAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=c2z9mWv897AVS-nBUf8A:9 a=CjuIK1q_8ugA:10 a=_bBvcJC8wCc67rcU61zu:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 587C015B1; Wed, 25 Jan 2017 19:55:14 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v0Q3tEhF092816; Wed, 25 Jan 2017 19:55:14 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201701260355.v0Q3tEhF092816@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Bruce Evans cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312780 - head/contrib/ipfilter/tools In-Reply-To: Message from Bruce Evans of "Thu, 26 Jan 2017 14:50:47 +1100." <20170126144726.U1265@besplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 25 Jan 2017 19:55:14 -0800 X-CMAE-Envelope: MS4wfG0C7oAfos8465steEpORf7VURWsV84CzUvdQeJjrbQz7DuDMyjTkuHCrvDwuBTi4PcGGO14/5Ad7UK+JAYoDYdU8EKHoQ7LsWszB6rgGIVnYfUyG7Xc juWY3Tkbv6daB35VYcRKwuJ5y2/e/gKDk3jAewcMwVNYJZZ3BXD0VqWejW8OD0lqjt2jxvjcqi1ZymMayLHGSj9gSWE9+T7KhsIJvLsGgx+ES17+XDRC6r6o AA2Hy0g9WZX98NsfwpanE0SOE0nWpl0jcchuPo3wn5AoZPhKRziCzsuhulFgCR769cpqhiysDgRfL0m68nnJzg== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2017 03:55:23 -0000 In message <20170126144726.U1265@besplex.bde.org>, Bruce Evans writes: > On Wed, 25 Jan 2017, Cy Schubert wrote: > > > Log: > > Remove extraneous blank line. > > > > MFC after: 2 weeks > > X-MFC with: r312777 > > > > Modified: > > head/contrib/ipfilter/tools/ipf.c > > > > Modified: head/contrib/ipfilter/tools/ipf.c > > =========================================================================== > === > > --- head/contrib/ipfilter/tools/ipf.c Wed Jan 25 20:59:06 2017 > (r312779) > > +++ head/contrib/ipfilter/tools/ipf.c Wed Jan 25 20:59:23 2017 > (r312780) > > @@ -409,7 +409,6 @@ static void flushfilter(arg, filter) > > closedevice(); > > return; > > } > > - > > else if (strchr(arg, 'i') || strchr(arg, 'I')) > > fl = FR_INQUE; > > else if (strchr(arg, 'o') || strchr(arg, 'O')) > > Now it has 1 extra instead of 2 extra. > > Most code in ipfilter, and all in the old version of this file, uses the > normal KNF style of cuddling elses. I suppose I should compress it one more. I'll do that after the change window I'm working on tonight (if it's not too late and I'm not too tired). Thanks for your input Bruce. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.