Date: Sat, 23 Jun 2018 17:27:29 +0200 From: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> To: freebsd-pf@freebsd.org Subject: Re: pfr_update_stats: assertion failed. Message-ID: <20180623152729.GA81271@plan-b.pwste.edu.pl> In-Reply-To: <20161016181713.GA95110@plan-b.pwste.edu.pl> References: <20161016181713.GA95110@plan-b.pwste.edu.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--2fHTh5uZTiUOsy+g
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Oct 16, 2016 at 08:17:13PM +0200, Marek Zarychta wrote:
> The issue occurred first two years ago, after upgrade from 8 to 9
> branch. Now this i386 machine is running 11.0-STABLE and despite it was
> compiled with "WITHOUT_ASSERT_DEBUG=3Dyes", still from time to time
> message buffer is fed with:
> pfr_update_stats: assertion failed.
> pfr_update_stats: assertion failed.
> pfr_update_stats: assertion failed.
> pfr_update_stats: assertion failed.
> pfr_update_stats: assertion failed.
> pfr_update_stats: assertion failed.
> pfr_update_stats: assertion failed.
These messages are still filling system message buffer. According to
pfctl (8) there is nothing wrong with incrementing "XPass" counters
instead of the "Pass" counters. The message "pfr_update_stats: assertion
failed" is printed for debugging purposes only. One could also compare
the counters with the command "pfctl -sT -vv".=20
OpenBSD converted printf()'s to DPFDEBUG() macro in their sources almost
8 years ago. Only this printf() in pf_table.c has been converted to the
level of LOG_DEBUG [1].
Perhaps this line of code could be removed from FreeBSD PF sources?
--- sys/netpfil/pf/pf_table.orig.c 2018-06-23 16:40:14.876882000 +0200
+++ sys/netpfil/pf/pf_table.c 2018-06-23 16:40:23.621384000 +0200
@@ -1986,5 +1986,4 @@
if ((ke =3D=3D NULL || ke->pfrke_not) !=3D notrule) {
if (op_pass !=3D PFR_OP_PASS)
- printf("pfr_update_stats: assertion failed.\n");
op_pass =3D PFR_OP_XPASS;
}
[1] http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/net/pf_table.c?rev=3D1=
=2E86&content-type=3Dtext/x-cvsweb-markup
--=20
Marek Zarychta
--2fHTh5uZTiUOsy+g
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAABCAAdFiEEMOqvKm6wKvS1/ZeCdZ/s//1SjSwFAlsuZt4ACgkQdZ/s//1S
jSznEwgAmde6gZb+hmM6oz9wIVREKETKUr7+pvrECYkq1OY57RnW5zANHbJOG6xM
A1Y/XNaGL2Jk7OPvfcyL/edCBLGM0wf+u0neyQv3bPECi78/kdkyvA6Hf+gp3Eag
ScF6LwqYP2wnhzFnX+PgcHYdgPUmCDz1wKcKxkPR/pW9oB024aUuM7kF0oeMkSZ0
M6cz0Kh5NoQvL+ObqlEdmYgOSDyXxD+6SN42laJiAj5xjmtCHBFBwYjQcs/3Jwok
4XNFZr2Xqbwcr7GzGFR7Ppddk5d6jCIyuRDvptK55hbf0w957D19Wmn14i5zP9Zu
kNrM3rHI0HxxXLjv6VFhigVxxAEbFQ==
=5WVh
-----END PGP SIGNATURE-----
--2fHTh5uZTiUOsy+g--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180623152729.GA81271>