From owner-svn-src-all@freebsd.org Tue Sep 3 12:54:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5317DDA101 for ; Tue, 3 Sep 2019 12:54:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N6NG2JKnz4K6V for ; Tue, 3 Sep 2019 12:54:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id 201so6211297qkd.13 for ; Tue, 03 Sep 2019 05:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P5uN4YjRwr9KJtVUFSQQ9H60NF+ba4dFcW2Jay1ozDo=; b=ubaxNTBE27QP3IkC881vd31O4cvE0pk2aJRlgfuEFz2rz82fU20RWQPbDQmIPufIT+ JL4VHr6XQuwufH6l2ujoliyU/pp8l3p1O9eNb6rP336PMyKnftlx3yrx+siamYGawWMv iQOQ+35D10Ovo+dk2MqwxM5O1bomSf4VbmKxAu3e6r9BOLQ0vlLhNxn7zipMB308g9e6 rCOvyov08qW20tDJvflx2yOL3ozTJ0uOVU0F6Mm56PQcyj82MYrgae9O3KUMmDPq1edR o2zR2L1ircejPrQZax1ASXhb24I3Kxh+ZnR9ZGBypVu3iAW0gt0wJVLIuOvlBbAVqIjS dzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P5uN4YjRwr9KJtVUFSQQ9H60NF+ba4dFcW2Jay1ozDo=; b=MsZYGkgqFaEM21fBw3/SPr2BgQvg5hP6SFXdIq+t4PU0aQH0/I17r0EAVmJFvu7Ixv KCzeHAjaerVdJYDUg+EsgmRJNwGl6txq+bT/Z0mnjcUjFFBOBkeLonIbnr9G955tKOVW 2/BbGS5VjgcxUXnRyhkbHDWW7fenbuNXC4IoB9N6rqnS8AZa71Fzxw0xXaDZHcKvnm91 r88bzVfv+7pWL6EN4CAancf3Schiy8kHOrzaoPh3PgLHxPj5183icEHy+fdwxF5wzr2K NUFfPWaTIJKtuIu6ygjdjOABE/FKWjALahyS8dXXH9BzbMzd4ac8wUm/HMprT304mzAU S8qg== X-Gm-Message-State: APjAAAUisMl9TZ+qqG/22B4gYG4jnOq3vzebcgisyaO0knVMOckktQfC G/ekKSVU9thDcyzTJbj2qFtKtoIcxOPhi7c59L+W7g== X-Google-Smtp-Source: APXvYqyFe/C8PvCFLOJDeD6nNhETm2nKi46L5psku1ER1XsXz8WAwqS9hpE8phP9kjrQ45L2urSW5j2KccaGxE6L+Gs= X-Received: by 2002:a05:620a:16ab:: with SMTP id s11mr6738843qkj.215.1567515260859; Tue, 03 Sep 2019 05:54:20 -0700 (PDT) MIME-Version: 1.0 References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> In-Reply-To: <20190903114523.GA68094@spindle.one-eyed-alien.net> From: Warner Losh Date: Tue, 3 Sep 2019 06:54:09 -0600 Message-ID: Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys To: Brooks Davis Cc: Shawn Webb , Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 46N6NG2JKnz4K6V X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=ubaxNTBE; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::734) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.91 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; RCVD_IN_DNSWL_NONE(0.00)[4.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.92)[ip: (-9.40), ipnet: 2607:f8b0::/32(-2.82), asn: 15169(-2.30), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 12:54:23 -0000 On Tue, Sep 3, 2019, 5:45 AM Brooks Davis wrote: > On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > > Hey Mateusz, > > > > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > > > Author: mjg > > > Date: Tue Sep 3 04:16:30 2019 > > > New Revision: 351729 > > > URL: https://svnweb.freebsd.org/changeset/base/351729 > > > > > > Log: > > > Add sysctlbyname system call > > > > > > Previously userspace would issue one syscall to resolve the sysctl > and then > > > another one to actually use it. Do it all in one trip. > > > > > > Fallback is provided in case newer libc happens to be running on an > older > > > kernel. > > > > > > Submitted by: Pawel Biernacki > > > Reported by: kib, brooks > > > Differential Revision: https://reviews.freebsd.org/D17282 > > > > > > Modified: > > ... snip ... > > > head/sys/sys/param.h > > > > ... snip ... > > > > > > > > Modified: head/sys/sys/param.h > > > > ============================================================================== > > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 (r351728) > > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 (r351729) > > > @@ -60,7 +60,7 @@ > > > * in the range 5 to 9. > > > */ > > > #undef __FreeBSD_version > > > -#define __FreeBSD_version 1300044 /* Master, propagated to newvers */ > > > +#define __FreeBSD_version 1300045 /* Master, propagated to newvers */ > > > > To an outsider, it seems that __FreeBSD_version tends to be bumped in > > a separate commit. Am I remembering that right? > > It should be bumped in the same commit, but people forget or the bump > they have in their review turns into a no-op because someone else does a > bump in the interim (the latter has bit me several times). > Often when that happens to me, I'll just piggyback off the prior bump by just documenting the version bump as also covering what I just did. Though there is some judgement too based on number of days and how bad the effects in the in between zone might be. It's always a fuzzy thing if you zoom in on it, though, due to after the fact bumps. Warner >