From owner-svn-ports-all@FreeBSD.ORG Tue Nov 27 16:14:52 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2D2D12C5; Tue, 27 Nov 2012 16:14:52 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B37978FC13; Tue, 27 Nov 2012 16:14:50 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id je9so5061959bkc.13 for ; Tue, 27 Nov 2012 08:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=AVyDkgYQAhDsOtmuanwE5yUI4j76WWzQuldad3s05TA=; b=Kd8mbpXklaHebrX0b9HZW8+yoQfaq/1mduKJGMcANJbRyR/X1YwNa3IukO79fTUSyV 0uD0SM+qf1ae89QL/KQcc/JtYH2YWiCiBg+e9ZhpkVGmUS3LrWB9FgzwgrZk5AJhgzHL 77Rdvh7uCsq5LP0tzYb9dg7fdoVtjmTHUPtohr1ljxFZnluKzMMbNBFpX/m4utOtp+uE nsqBs4PDeKJDKBt60c73OqCWdCOkJmW+qYUFkI2pGGCd6L9ZWLTJXXfBfABZ/MXgHvsa CNUK7GK4SR8Eh1DSTwWXGO6x7bZjNDMdwdvM2x2XW9OPFA50Z2bQdY+ng/oZKzvVruIc WDlA== MIME-Version: 1.0 Received: by 10.204.147.22 with SMTP id j22mr4636681bkv.66.1354032883703; Tue, 27 Nov 2012 08:14:43 -0800 (PST) Received: by 10.204.167.71 with HTTP; Tue, 27 Nov 2012 08:14:43 -0800 (PST) Received: by 10.204.167.71 with HTTP; Tue, 27 Nov 2012 08:14:43 -0800 (PST) In-Reply-To: <20121127160133.GC72381@FreeBSD.org> References: <201211271205.qARC54XQ060171@svn.freebsd.org> <20121127125610.GA59490@FreeBSD.org> <20121127133107.GA740@ravenloft.kiev.ua> <20121127135846.GA63249@FreeBSD.org> <20121127151842.GA5768@ravenloft.kiev.ua> <20121127155046.GA72381@FreeBSD.org> <20121127160133.GC72381@FreeBSD.org> Date: Tue, 27 Nov 2012 16:14:43 +0000 Message-ID: Subject: Re: svn commit: r307837 - head/comms/morse From: Chris Rees To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Alex Kozlov , Eitan Adler , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 16:14:52 -0000 On 27 Nov 2012 16:01, "Alexey Dokuchaev" wrote: > > On Tue, Nov 27, 2012 at 10:54:00AM -0500, Eitan Adler wrote: > > On 27 November 2012 10:50, Alexey Dokuchaev wrote: > > > It is not just a matter of aesthetics, it's reducing environment pollution > > > with gratuitously different names of standard knobs. As for POLA, these > > > days people are supposed to cache their OPTIONS selection in /var/db/ports > > > instead of hardcoding them in /etc/make.conf. Upon upgrade, dialog will > > > pop up again since OPTIONS had changed, nothing should go unnoticed here. > > > > Some people do not want to use the dialog(1) interface. Using > > /etc/make.conf is expected and fully supported. We should not > > gratuitously break option names. > > OK; however, in this case we're not gratuitously breaking it, we're changing > bogus name to more explicit, standard, used in many other ports name. > > If someone feels badly about it, UPDATING note can be added, although IMHO > in this case nothing really warrants it. It is not particularly popular > port, and it's better to fix these issues early rather that later. Dixi, We can also leave compat shims in if people get very angry. Chris