From nobody Mon Mar 18 12:04:40 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tytns5zP5z5Dbj5; Mon, 18 Mar 2024 12:04:49 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tytns1Q0pz44Xs; Mon, 18 Mar 2024 12:04:49 +0000 (UTC) (envelope-from tuexen@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:c6a0:3052:202:550a:8b4c:ffef:3f6f]) (Authenticated sender: micmac) by drew.franken.de (Postfix) with ESMTPSA id 6DD94721E2806; Mon, 18 Mar 2024 13:04:41 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: Request for Testing: TCP RACK From: tuexen@freebsd.org In-Reply-To: Date: Mon, 18 Mar 2024 13:04:40 +0100 Cc: garyj@gmx.de, current@freebsd.org, net@freebsd.org, Randall Stewart Content-Transfer-Encoding: quoted-printable Message-Id: References: <42C327BD-6CE4-43AA-A1AE-3BEC08D623DB@freebsd.org> <486915F0-456B-4B09-A8BC-93BBA79C4CA1@freebsd.org> <20240313080624.6c73908c@ernst.home> <508E3B47-8E1B-469F-97B1-2171A3098888@freebsd.org> <86a5n1i0xg.fsf@ltc.des.dev> <78D1FF09-71A3-4486-B934-D8332F54B237@freebsd.org> <20240316104053.20bef8c2@ernst.home> <20240316115128.33d11f7b@ernst.home> <7367F29A-D52B-4828-B79A-AA2667E81E7D@freebsd.org> <4FF534F6-B35D-4596-8D1E-226AD1347AC8@freebsd.org> <6e795e9c-8de4-4e02-9a96-8fabfaa4e66f@app.fastmail.com> To: Nuno Teixeira , Drew Gallatin X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:680, ipnet:2001:638::/32, country:DE] X-Rspamd-Queue-Id: 4Tytns1Q0pz44Xs > On 18. Mar 2024, at 12:42, Nuno Teixeira wrote: >=20 > Hello all! >=20 > It works just fine! > System performance is OK. > Using patch on main-n268841-b0aaf8beb126(-dirty). >=20 > --- > net.inet.tcp.functions_available: > Stack D Alias PCB = count > freebsd freebsd 0 > rack * rack 38 > --- >=20 > It would be so nice that we can have a sysctl tunnable for this patch > so we could do more tests without recompiling kernel. Thanks for testing! @gallatin: can you come up with a patch that is acceptable for Netflix and allows to mitigate the performance regression. Best regards Michael >=20 > Thanks all! > Really happy here :) >=20 > Cheers, >=20 > Nuno Teixeira escreveu (domingo, 17/03/2024 = =C3=A0(s) 20:26): >>=20 >> Hello, >>=20 >>> I don't have the full context, but it seems like the complaint is a = performance regression in bonnie++ and perhaps other things when = tcp_hpts is loaded, even when it is not used. Is that correct? >>>=20 >>> If so, I suspect its because we drive the tcp_hpts_softclock() = routine from userret(), in order to avoid tons of timer interrupts and = context switches. To test this theory, you could apply a patch like: >>=20 >> It's affecting overall system performance, bonnie was just a way to >> get some numbers to compare. >>=20 >> Tomorrow I will test patch. >>=20 >> Thanks! >>=20 >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) >=20 >=20 >=20 > --=20 > Nuno Teixeira > FreeBSD Committer (ports)