From owner-freebsd-hackers  Wed Jun  7 05:30:03 1995
Return-Path: hackers-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id FAA16768
          for hackers-outgoing; Wed, 7 Jun 1995 05:30:03 -0700
Received: from asstdc.scgt.oz.au (root@asstdc.scgt.oz.au [202.14.234.65])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id FAA16731
          for <freebsd-hackers@freebsd.org>; Wed, 7 Jun 1995 05:29:30 -0700
Received: (from imb@localhost)
	by asstdc.scgt.oz.au (8.6.12/BSD4.4)
	id WAA05991; Wed, 7 Jun 1995 22:28:18 +1000
From: michael butler <imb@scgt.oz.au>
Message-Id: <199506071228.WAA05991@asstdc.scgt.oz.au>
Subject: Re: silo overflows
To: bde@zeta.org.au (Bruce Evans)
Date: Wed, 7 Jun 1995 22:28:17 +1000 (EST)
Cc: freebsd-hackers@freebsd.org
In-Reply-To: <199506070736.RAA06651@godzilla.zeta.org.au> from "Bruce Evans" at Jun 7, 95 05:36:26 pm
X-Mailer: ELM [version 2.4 PL24beta]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 854       
Sender: hackers-owner@freebsd.org
Precedence: bulk

Bruce Evans writes:

> >Is the current solution to change the FIFO_TRIGGER_14
> >value in sioreg.h to something lower ?
 
> No, FIFO_TRIGGER_14 is a constant, not an option.  Change the one
> place in sio.c where it is used to initialize com->ftl_init.  Use
> FIFO_TRIGGER_8 instead.

Could this be "externalised", please. I have a mix of machines from 386DX/40
through 486DX2/66 working from the same (-current) source set and a line in
the machine-dependent config file would be more appropriate and convenient
than having to edit the O/S sources each time I sup an update. 

options	"FIFO_TRIGGER=FIFO_TRIGGER_8"

 .. and ..

#ifndef FIFO_TRIGGER
#define FIFO_TRIGGER FIFO_TRIGGER_14
#endif

	:

com->ftl_init = FIFO_TRIGGER;

 .. is all that's necessary. If at all possible, site-dependent "hacks"
should be kept out of the kernel sources.

	michael