From owner-svn-src-stable@freebsd.org Mon Nov 11 10:10:04 2019 Return-Path: Delivered-To: svn-src-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 16E421B144F; Mon, 11 Nov 2019 10:10:04 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47BRSq6wyhz40lM; Mon, 11 Nov 2019 10:10:03 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id BA3751D064; Mon, 11 Nov 2019 10:10:03 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [192.168.1.58] (92-111-45-100.static.v4.ziggozakelijk.nl [92.111.45.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 280B92C1E3; Mon, 11 Nov 2019 11:10:02 +0100 (CET) From: Dimitry Andric Message-Id: <4FEA5BCC-A9E7-4FDB-8392-04027239D9B0@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_B7FA7644-3FA1-4324-BA00-4497784FC089"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r354598 - in stable: 11/contrib/libc++/include 11/sys/sys 12/contrib/libc++/include 12/sys/sys Date: Mon, 11 Nov 2019 11:09:57 +0100 In-Reply-To: Cc: src-committers , svn-src-all , svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org To: Antoine Brodin References: <201911101841.xAAIfEXV088995@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.104.11) X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Nov 2019 10:10:04 -0000 --Apple-Mail=_B7FA7644-3FA1-4324-BA00-4497784FC089 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 11 Nov 2019, at 10:29, Antoine Brodin wrote: > > On Mon, Nov 11, 2019 at 9:03 AM Antoine Brodin wrote: >> >> On Sun, Nov 10, 2019 at 7:41 PM Dimitry Andric wrote: >>> >>> Author: dim >>> Date: Sun Nov 10 18:41:13 2019 >>> New Revision: 354598 >>> URL: https://svnweb.freebsd.org/changeset/base/354598 >>> >>> Log: >>> MFC r354460: >>> >>> Merge commit e8316372b from llvm git (by Louis Dionne): >>> >>> [libc++] Add `__truncating_cast` for safely casting float types to >>> integers >>> >>> This is needed anytime we need to clamp an arbitrary floating point >>> value to an integer type. >>> >>> Thanks to Eric Fiselier for the patch. >>> >>> Differential Revision: https://reviews.llvm.org/D66836 >>> >>> llvm-svn: 370891 >>> >>> Merge commit b92deded8 from llvm git (by Louis Dionne): >>> >>> [libc++] Move __clamp_to_integral to , and harden against >>> min()/max() macros >>> >>> llvm-svn: 370900 >>> >>> Merge commit 0ec6a4882 from llvm git (by Louis Dionne): >>> >>> [libc++] Fix potential OOB in poisson_distribution >>> >>> See details in the original Chromium bug report: >>> https://bugs.chromium.org/p/chromium/issues/detail?id=994957 >>> >>> Together, these fix a security issue in libc++'s implementation of >>> std::poisson_distribution, which can be exploited to read data which is >>> out of bounds. >>> >>> Note there are no programs in the FreeBSD base system that use >>> std::poisson_distribution, so this is only a possible issue for ports >>> and external programs which have been built against libc++. Therefore, >>> I am bumping __FreeBSD_version for the benefit of our port maintainers. >>> >>> Requested by: emaste >>> Security: potential OOB read >>> >>> Modified: >>> stable/11/contrib/libc++/include/cmath >>> stable/11/contrib/libc++/include/random >>> stable/11/sys/sys/param.h >>> Directory Properties: >>> stable/11/ (props changed) >>> >>> Changes in other areas also in this revision: >>> Modified: >>> stable/12/contrib/libc++/include/cmath >>> stable/12/contrib/libc++/include/random >>> stable/12/sys/sys/param.h >>> Directory Properties: >>> stable/12/ (props changed) >> >> Hi, >> >> It seems that some recent changes to stable/11 are broken, lots of >> ports now fail to build on stable/11. > > This affects stable/12 too. > It seems that the cmath header can't be compiled. Interesting, it works fine here on e.g. stable/12: $ cat test-cmath.cpp #include $ c++ -c test-cmath.cpp Are there any build logs available showing errors? -Dimitry --Apple-Mail=_B7FA7644-3FA1-4324-BA00-4497784FC089 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXckzdQAKCRCwXqMKLiCW o4y3AJ9GvaN7RcZPoaiwVm7G4oQaH+ly3ACeLF7IErSgpIbwNqNn6argKKIdGpE= =MZkc -----END PGP SIGNATURE----- --Apple-Mail=_B7FA7644-3FA1-4324-BA00-4497784FC089--