From owner-cvs-src@FreeBSD.ORG Sat Feb 14 01:32:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D45916A4CE; Sat, 14 Feb 2004 01:32:57 -0800 (PST) Received: from admin.x.com (unknown [210.172.132.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE8C143D1D; Sat, 14 Feb 2004 01:32:56 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mail pickup service by admin.x.com with Microsoft SMTPSVC; Sat, 14 Feb 2004 18:32:56 +0900 Received: from mxforward01.ms.interq.net ([172.16.5.24]) by ex2kmail01.x.com with Microsoft SMTPSVC(5.0.2195.6713); Fri, 13 Feb 2004 02:00:55 +0900 Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) i1CH3MXC001741 for ; Fri, 13 Feb 2004 02:03:22 +0900 (JST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 6B75456F3E; Thu, 12 Feb 2004 09:03:18 -0800 (PST) (envelope-from owner-cvs-all@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id AE64516A4D5; Thu, 12 Feb 2004 09:03:17 -0800 (PST) Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7061016A4CE; Thu, 12 Feb 2004 09:02:50 -0800 (PST) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8BAB43D1D; Thu, 12 Feb 2004 09:02:49 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i1CH2mLE027658; Fri, 13 Feb 2004 04:02:48 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i1CH2ki1019490; Fri, 13 Feb 2004 04:02:47 +1100 Date: Fri, 13 Feb 2004 04:02:46 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp In-Reply-To: <20040120175334.W3279@gamplex.bde.org> Message-ID: <20040213035557.M24031@gamplex.bde.org> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <20040120175334.W3279@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-cvs-all@freebsd.org Errors-To: owner-cvs-all@freebsd.org X-OriginalArrivalTime: 12 Feb 2004 17:00:55.0539 (UTC) FILETIME=[C770FC30:01C3F189] cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2004 09:32:57 -0000 On Tue, 20 Jan 2004, Bruce Evans wrote: > On Mon, 19 Jan 2004, Poul-Henning Kamp wrote: > > > phk 2004/01/19 13:27:11 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/alpha/alpha support.s > > sys/i386/i386 swtch.s > > sys/kern kern_shutdown.c > > sys/sys systm.h > > Log: > > Add linenumber and source filename to panic(9) output. > > This was rejected in all reviews. It gives less information than > grepping the sources, at some cost (grep at least gives correct line > numbers when the sources don't quite match the binary). > > Please back this out. I'm still waiting for this to be backed out. I just found yet another bug in it: it defeats simple regression checks. Suppose you make some cosmetic changes that add a line before a panic. This now changes the object file even when the file is compiled without -g. Bruce _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"