From owner-svn-src-all@freebsd.org Sun Nov 22 07:55:44 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C32362E82A3; Sun, 22 Nov 2020 07:55:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cf2dr2xFHz4hMH; Sun, 22 Nov 2020 07:55:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 0AM7tSTi049974 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 22 Nov 2020 09:55:31 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 0AM7tSTi049974 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 0AM7tS0L049973; Sun, 22 Nov 2020 09:55:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 22 Nov 2020 09:55:28 +0200 From: Konstantin Belousov To: Kyle Evans Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367928 - in head/sys: compat/freebsd32 kern sys Message-ID: References: <202011220534.0AM5Yp4u071733@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202011220534.0AM5Yp4u071733@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4Cf2dr2xFHz4hMH X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2020 07:55:44 -0000 On Sun, Nov 22, 2020 at 05:34:51AM +0000, Kyle Evans wrote: > Author: kevans > Date: Sun Nov 22 05:34:51 2020 > New Revision: 367928 > URL: https://svnweb.freebsd.org/changeset/base/367928 > > Log: > _umtx_op: move compat32 definitions back in > > These are reasonably compact, and a future commit will blur the compat32 > lines by supporting 32-bit operations with the native _umtx_op. I do not mind much about placement of the compat32 syscall stubs, but I did suggested and liked move of the compat32 structures definitions into freebsd32.h. They are actually useful that way, at least allowing me to write some (private) tests in the past.