Date: Thu, 08 Nov 2012 08:56:46 -0600 From: Joseph a Nagy Jr <jnagyjr1978@gmail.com> To: gahr@FreeBSD.org Cc: ports@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: tk85 Port Maintenance Message-ID: <509BC82E.2000206@gmail.com> In-Reply-To: <20121108091333.GN90275@gahrfit.gahr.ch> References: <20121031152109.GD90275@gahrfit.gahr.ch> <CADLo83_VSLt5t31bJbu3-UCuGkNuNnnBEbMXWVd2fhvVwryP5g@mail.gmail.com> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch> <50968056.8080602@gmail.com> <20121106082040.GM90275@gahrfit.gahr.ch> <509AEACB.1020909@gmail.com> <20121108091333.GN90275@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig91B02D1EE9430BFF34BFFF14
Content-Type: multipart/mixed;
boundary="------------060705010604060003050502"
This is a multi-part message in MIME format.
--------------060705010604060003050502
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 11/08/12 03:13, Pietro Cerutti wrote:
> On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote:
>> On 11/06/12 02:20, Pietro Cerutti wrote:
>> <snip>
>>> * I won't comment on the LICENSE stuff, I don't know enough about it
>>>
>>> * XFT_DESC
>>> This is already defined in bsd.options.desc.mk. I'd say that=20
>>> "Xft font library" is ok as a description.
>>>
>>> * LIB_DEPENDS+=3D Xft:${PORTSDIR}/x11-fonts/libXft
>>> This should really be
>>> USE_XORG+=3D xft
>>>
>>> * LIB_DEPENDS=3D tcl${SHORT_TK_VER}${THREADS_SUFFIX}:....
>>> If you're ok to wait until I get rid of the -thread slave ports,
>>> you don't need to bother about this part of the Makefile
>>>
>>
>> svn checked out, svn diff
>>
>> http://pastebin.com/kLdUFp9H
>=20
> -XFT_DESC=3D Use Xft fonts
> +XFT_DESC=3D Xft font library
>=20
> This is not needed. As I said, XFT_DESC is already defined in
> bsd.options.desc.mk
Sorry, misunderstood.
>=20
> The tr -> ${TR} conversion is also wrong, you're changing what the sed
> liner is looking for. If you do so, it won't find it anymore.
That was one of many suggestions from portlint.
> By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days
> (the first RC is out now, actually). You might want to include the
> update in your diff :)
>=20
I'll get on it.
--=20
Yours in Christ,
Joseph A Nagy Jr
"Whoever loves instruction loves knowledge, But he who hates correction
is stupid." -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
--------------060705010604060003050502--
--------------enig91B02D1EE9430BFF34BFFF14
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQEcBAEBAgAGBQJQm8gwAAoJECqR4kIlFcuBsKYIAJ/t/BuxOJFRneQy08lxsJzn
PsoK5FZBYkRmhm7VisMZZ+FBdagybgGUEF79KSzGwAIkWVcYr24Pv6yZC0PBTbFp
m/1DQ9jkb8l2UqtX4uLrfLFbHig0g5MZo8hywNjY1jK1P/QBathbPgjRzxqY4hck
NtNqLDjEjLDPKiv/ft+l1AO2hHbObw4fR/pRLRIYsjUov7ypaX4ocQj+RlI9+vpO
ep4BxfPYWjWTHpENIU16+ePzbHUnTAOAFN8nEdwHn8KhkOOwdNkLpz3UZfHiFCMt
Rb/vcLHngP1KH2z2+NVKypslajj4Nt4ozLrZZCpd953lC7hV9aioQjgVGCkJuiQ=
=YFqP
-----END PGP SIGNATURE-----
--------------enig91B02D1EE9430BFF34BFFF14--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?509BC82E.2000206>