From owner-freebsd-mobile  Wed Jan  8 22:38:20 2003
Delivered-To: freebsd-mobile@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 11C2E37B401
	for <freebsd-mobile@FreeBSD.ORG>; Wed,  8 Jan 2003 22:38:18 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2C41C43F13
	for <freebsd-mobile@FreeBSD.ORG>; Wed,  8 Jan 2003 22:38:17 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.6/8.12.3) with ESMTP id h096cF1e079810;
	Wed, 8 Jan 2003 23:38:15 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Wed, 08 Jan 2003 23:38:11 -0700 (MST)
Message-Id: <20030108.233811.50337960.imp@bsdimp.com>
To: freebsd-mobile@FreeBSD.ORG, pir@pir.net
Subject: Re: Thinkpad X30, wireless card
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030108211532.GF18309@pir.net>
References: <20030105090809.GK17859@pir.net>
	<20030105.161802.122420996.imp@bsdimp.com>
	<20030108211532.GF18309@pir.net>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-mobile.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-mobile>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-mobile>
X-Loop: FreeBSD.org

In message: <20030108211532.GF18309@pir.net>
            Peter Radcliffe <pir@pir.net> writes:
: "M. Warner Losh" <imp@bsdimp.com> probably said:
: > At a minimum, you'll need to save the BARs in suspend (maybe setting
: > the power state to D3 afterwards) and then restore them afterwards
: > (after setting the power state to D0)....
: 
: I was talking to a couple of people about the general FreeBSD
: compatability of the X30 and mentioned this problem. One of the people
: was winter and he came up with a couple of test patches, this one
: seems to have fixed the problem for me.

OK.
: + static int
: + wi_pci_suspend (device_t dev)
: + {
: + 	return (0);

NetBSD has
	wi_stop(ifp, 1);
in a similar location.

: + }

: + static int
: + wi_pci_resume (device_t dev)
: + {
: + 	struct wi_softc		*sc;
: + 	struct ifnet		*ifp;
: + 	sc = device_get_softc(dev);
: + 
: + 	if (sc->wi_bus_type != WI_BUS_PCI_NATIVE)
: + 	  return (0);
: + 
: + 	ifp = &sc->arpcom.ac_if;
: + 	ifp->if_init(ifp->if_softc);
: +  

and
		if (ifp->if_flags & IFF_UP) {
			wi_init(ifp);
			(void)wi_intr(sc);
		}

here.

So I suspect that those are better patches.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message