Date: Mon, 7 Aug 2017 22:42:46 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r322206 - head/sys/geom Message-ID: <201708072242.v77Mgk5H038376@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Mon Aug 7 22:42:46 2017 New Revision: 322206 URL: https://svnweb.freebsd.org/changeset/base/322206 Log: Eliminate useless adjustments of aliased device. No need to set any fields in the cloned device. devfs uses symlinks, so the adev entries returned won't be presented to the drivers. Since we don't save copies, nothing else will see them. This code came from the old compat code, and it appears to be obsolete or never needed. Submitted by: kib@ Differential Review: https://reviews.freebsd.org/D11919 Modified: head/sys/geom/geom_dev.c Modified: head/sys/geom/geom_dev.c ============================================================================== --- head/sys/geom/geom_dev.c Mon Aug 7 22:30:18 2017 (r322205) +++ head/sys/geom/geom_dev.c Mon Aug 7 22:42:46 2017 (r322206) @@ -369,9 +369,6 @@ g_dev_taste(struct g_class *mp, struct g_provider *pp, __func__, gap->ga_alias, error); continue; } - adev->si_flags |= SI_UNMAPPED; - adev->si_iosize_max = dev->si_iosize_max; - adev->si_drv2 = dev->si_drv2; snprintf(buf, sizeof(buf), "cdev=%s", gap->ga_alias); devctl_notify_f("GEOM", "DEV", "CREATE", buf, M_WAITOK); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201708072242.v77Mgk5H038376>