Date: Wed, 10 Apr 2013 14:46:31 +1000 (AEST) From: John Marshall <john.marshall@riverwillow.com.au> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/177746: [PATCH] devel/subversion fbsd template 'Sponsored by:' cleanup Message-ID: <201304100446.r3A4kVHl061956@rwsrv08.mby.riverwillow.net.au> Resent-Message-ID: <201304100450.r3A4o1Tw040426@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 177746
>Category: ports
>Synopsis: [PATCH] devel/subversion fbsd template 'Sponsored by:' cleanup
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Apr 10 04:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: John Marshall
>Release: FreeBSD 9.1-RELEASE-p2 amd64
>Organization:
Riverwillow Pty Ltd
>Environment:
System: FreeBSD rwsrv08.mby.riverwillow.net.au 9.1-RELEASE-p2 FreeBSD 9.1-RELEASE-p2 #0 r249032: Wed Apr 3 09:12:20 AEDT 2013 root@rwsrv08.mby.riverwillow.net.au:/usr/obj/usr/src/sys/RWSRV08 amd64
>Description:
r314983 added 'Sponsored by:' to the FreeBSD template prefix array
without incrementing the defined number of elements in the array. The
effect is that the 'Sponsored by:' field is added to the commit log
template but is never removed.
>How-To-Repeat:
Commit using the subversion port built since r314983; including the
FreeBSD template; and notice that 'Sponsored by:' becomes a permanent
feature of every commit log message.
>Fix:
The attached patch increments the array element count in the fbsd
template patch to catch up with addition of the new field. Whether or
not to bump PORTREVISION in the port's Makefile is left as an exercise
for the committer.
--- subversion_fbsd_template.diff begins here ---
Index: devel/subversion/files/extra-patch-fbsd-template
===================================================================
--- devel/subversion/files/extra-patch-fbsd-template (revision 315774)
+++ devel/subversion/files/extra-patch-fbsd-template (working copy)
@@ -20,7 +20,7 @@
+ * projects that won't be expecting them.
+ */
+
-+#define NPREFIX 7
++#define NPREFIX 8
+char *prefixes[NPREFIX] = {
+ "PR:",
+ "Submitted by:",
--- subversion_fbsd_template.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304100446.r3A4kVHl061956>