Date: Thu, 21 Mar 2002 06:25:04 -0700 (MST) From: "M. Warner Losh" <imp@village.org> To: jhb@freebsd.org Cc: peter@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 7933 for review Message-ID: <20020321.062504.18991423.imp@village.org> In-Reply-To: <XFMail.20020319131141.jhb@FreeBSD.org> References: <200203190929.g2J9TnB80357@freefall.freebsd.org> <XFMail.20020319131141.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <XFMail.20020319131141.jhb@FreeBSD.org>
John Baldwin <jhb@freebsd.org> writes:
:
: On 19-Mar-2002 Peter Wemm wrote:
: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7933
: >
: > Change 7933 by peter@peter_overcee on 2002/03/19 01:29:12
: >
: > add the ia64 IO tag, and add a #error to catch this in future.
: >
: > Affected files ...
: >
: > ... //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 edit
: >
: > Differences ...
: >
: > ==== //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 (text+ko) ====
: >
: > @@ -159,6 +159,10 @@
: > tag = I386_BUS_SPACE_IO;
: > #elif defined(__alpha__)
: > tag = busspace_isa_io;
: > +#elif defined(__ia64__)
: > + tag = IA64_BUS_SPACE_IO;
: > +#else
: > +#error "define tag!"
: > #endif
: >
: > #if notyet
:
: Maybe there should be a MD macro to define what the appropriate bus tag is?
No. atkbdc should be fixed to properly use the bus tag that the
kernel gives it rather than guessing. It needs to do this anyway if
we are ever to support some some PC Cards that have keyboard/mouse
ports on them.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020321.062504.18991423.imp>