From owner-svn-src-head@FreeBSD.ORG  Wed Jan 28 19:27:32 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B1B6B97D;
 Wed, 28 Jan 2015 19:27:32 +0000 (UTC)
Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 93E7AFA4;
 Wed, 28 Jan 2015 19:27:32 +0000 (UTC)
Received: from bender (c108.sec.cl.cam.ac.uk [128.232.18.108])
 by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id A8A7973000;
 Wed, 28 Jan 2015 19:27:24 +0000 (UTC)
Date: Wed, 28 Jan 2015 19:27:19 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Ruslan Bukin <br@FreeBSD.org>
Subject: Re: svn commit: r277835 - in head: lib/libpmc sys/arm/arm
 sys/arm/include sys/arm/ti sys/conf sys/dev/hwpmc sys/sys
Message-ID: <20150128192719.2baf6145@bender>
In-Reply-To: <20150128183913.GA44243@bsdpad.com>
References: <201501281608.t0SG88gs009253@svn.freebsd.org>
 <1422462903.15718.60.camel@freebsd.org>
 <20150128183913.GA44243@bsdpad.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Ian Lepore <ian@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2015 19:27:32 -0000

On Wed, 28 Jan 2015 18:39:13 +0000
Ruslan Bukin <br@FreeBSD.org> wrote:
> On Wed, Jan 28, 2015 at 09:35:03AM -0700, Ian Lepore wrote:
> > Just from a quick glance at the part that wasn't truncated, I
> > notice all the inline asm stuff is wrong -- it duplicates what's
> > already available in cpu-v6.h.
> > 
> 
> I had a conversation with Andrew this morning, he pointed me out
> those defines in cpu-v6.h, but we agreed those are optional stuff.
> I.e. duplicates != wrong. I'll fix that. Thanks

It would be useful to use them, but this will need Makefile changes as
some of these defines are only available when __ARM_ARCH > 6 which may
not be true in userland. If we do make these changes we then need to
make sure that none of the code on the file built as ARMv7 is run on an
ARMv6 as the compiler may choose to use invalid instructions on v6.

Andrew