From owner-svn-src-head@freebsd.org Thu Oct 13 07:39:07 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64793C0FE82 for ; Thu, 13 Oct 2016 07:39:07 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 189209AD for ; Thu, 13 Oct 2016 07:39:07 +0000 (UTC) (envelope-from julio@meroh.net) Received: by mail-yw0-x22b.google.com with SMTP id t193so47911146ywc.2 for ; Thu, 13 Oct 2016 00:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meroh.net; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9hJZ3YFwxU+q+af1MKtsqGdkC29+yV1JFAd6nJzT6Yw=; b=drw26ohdxBPmnchN7a/tGlvH4wRkSxnKy8xqFE7tG0VZvx3alEjkvz/xdwsf3DR2J0 4MGuQrM5NO4q2FfjyLkx05X9zyKkBP7tLKCA+TPcV7RjIjpHPhpZpbZ/DF/6aU9i6K4i dUeWK/+HwHvx6Rr7ARr/qXv9Yfuutn8Uu3CuCJMv70/ehXl3pEpX1xgTWOm7m+CEBBG5 V4Jd4JEAaW3aDOu2mZGzHlKAZy2rSwdV74+yu0jEMu5vjlU1q5Ggh+hcPSs65F6X34Fa 9PmgdYN2qu+xhUyhNE4wtoADrecohM5EubDb3Ier1KS5AIFLUxHYXo1gWmWGb5f55PQH 6yQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9hJZ3YFwxU+q+af1MKtsqGdkC29+yV1JFAd6nJzT6Yw=; b=UyCE0KcsNAJyifdaA3lhjn48gjpZ1z/V8e5tZV9/D1qNNs6/QZC1eSAqFnN3imJ/za 2wptq3EgoFukaYo12lAme81tvxZxHQdLV06R4kTDFkxO8qg0/HGYurP/ttSw9yfiw0v+ pE1hAjX84vBfN/xUIsh1ESOoeZ+QH0ZqLWuq6/mQqoRcz574BcDQngq/w9IuN+Tc0l48 QBQ0apFDpDRbvG/LfnccPY5F7aQGlPUboj2qFXBvScVfAGEMhTdL81OUXxqPB5Fh8Fgy YkmVTFaHA9hPC30E0Eupau0gZEryhc1Q9lRWlvqmbao9mS8Mex4OQyLZKhSgiqNSkF0y VY9g== X-Gm-Message-State: AA6/9RnqAvyTo/VKYmsLvjEqeBY/avTh+R/W3fhCRdx8AtVTSFN74KcSsPvSvjCiH8FCEIk6ZHQsgnVlFZn4Pg== X-Received: by 10.13.219.146 with SMTP id d140mr4423301ywe.61.1476344346347; Thu, 13 Oct 2016 00:39:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.170.108 with HTTP; Thu, 13 Oct 2016 00:38:44 -0700 (PDT) X-Originating-IP: [172.26.42.46] In-Reply-To: References: <201610130702.u9D72sgd007580@repo.freebsd.org> From: Julio Merino Date: Thu, 13 Oct 2016 03:38:44 -0400 Message-ID: Subject: Re: svn commit: r307190 - head/contrib/netbsd-tests/fs/tmpfs To: "Ngie Cooper (yaneurabeya)" Cc: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 07:39:07 -0000 On Thu, Oct 13, 2016 at 3:29 AM, Ngie Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > > > On Oct 13, 2016, at 00:20, Julio Merino wrote: > > > > On Thu, Oct 13, 2016 at 3:02 AM, Ngie Cooper wrote: > > Author: ngie > > Date: Thu Oct 13 07:02:54 2016 > > New Revision: 307190 > > URL: https://svnweb.freebsd.org/changeset/base/307190 > > > > Log: > > Skip :uchg on FreeBSD > > > > Unfortunately removing files with uchg set always succeeds with root = on > > FreeBSD. Unfortunately running the test as an unprivileged user isn't > doable > > because mounting tmpfs requires root > > > > PR: 212861 > > Sponsored by: Dell EMC Isilon > > > > Modified: > > head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh > > > > Modified: head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 > 06:56:23 2016 (r307189) > > +++ head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 > 07:02:54 2016 (r307190) > > @@ -53,6 +53,10 @@ uchg_head() { > > atf_set "require.user" "root" > > } > > uchg_body() { > > + # Begin FreeBSD > > + atf_skip "this fails on FreeBSD with root - bug 212861" > > + # End FreeBSD > > > > This is a bad way of disabling a test due to a known bug because, when > the bug is resolved, the test won't notice. You should be using the > "expected failures" functionality if possible, and based on the change > description, I think you can do this here easily. Try: > > > > atf_expect_fail "FreeBSD bug 213861 blah blah" > > > > right before the line that triggers the test failure. > > The problem is that this leaves tmpfs mounts lying around, which atf won= =E2=80=99t > cleanup. Otherwise, I would totally agree with you. > Replace: atf_test_case uchg with: atf_test_case uchg cleanup and then add: uchg_cleanup() { umount foo/bar 2>/dev/null || true } This is actually *necessary* regardless of how you skip the test to ensure the mount point is cleaned up on any failure of the test. If the tests are not doing that yet, they are bogus. --=20 Julio Merino -- http://julio.meroh.net/