Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Sep 2019 16:50:34 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r351662 - head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD
Message-ID:  <201909011650.x81GoYMF016778@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Sun Sep  1 16:50:34 2019
New Revision: 351662
URL: https://svnweb.freebsd.org/changeset/base/351662

Log:
  lldb: shorten thread names to make logs easier to follow
  
  lldb prepends the thread name to log entries, and the existing thread
  name for the FreeBSD ProcessMonitor thread was longer than the kernel's
  supported thread name length, and so was truncated.  This made logs hard
  to read, as the truncated thread name ran into the log message.  Shorten
  "lldb.process.freebsd.operation" to just "freebsd.op" so that logs are
  more readable.
  
  (Upstreaming to lldb still to be done).

Modified:
  head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

Modified: head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
==============================================================================
--- head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp	Sun Sep  1 16:47:48 2019	(r351661)
+++ head/contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp	Sun Sep  1 16:50:34 2019	(r351662)
@@ -809,7 +809,7 @@ ProcessMonitor::~ProcessMonitor() { StopMonitor(); }
 //------------------------------------------------------------------------------
 // Thread setup and tear down.
 void ProcessMonitor::StartLaunchOpThread(LaunchArgs *args, Status &error) {
-  static const char *g_thread_name = "lldb.process.freebsd.operation";
+  static const char *g_thread_name = "freebsd.op";
 
   if (m_operation_thread.IsJoinable())
     return;
@@ -975,7 +975,7 @@ FINISH:
 
 void ProcessMonitor::StartAttachOpThread(AttachArgs *args,
                                          lldb_private::Status &error) {
-  static const char *g_thread_name = "lldb.process.freebsd.operation";
+  static const char *g_thread_name = "freebsd.op";
 
   if (m_operation_thread.IsJoinable())
     return;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909011650.x81GoYMF016778>