From owner-freebsd-fs@FreeBSD.ORG  Wed Apr  2 13:38:00 2003
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 15F5F37B401; Wed,  2 Apr 2003 13:38:00 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5443D43FBD; Wed,  2 Apr 2003 13:37:59 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3])
	by fledge.watson.org (8.12.9/8.12.9) with SMTP id h32LcIYY039227;
	Wed, 2 Apr 2003 16:38:18 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Wed, 2 Apr 2003 16:38:18 -0500 (EST)
From: Robert Watson <rwatson@FreeBSD.ORG>
X-Sender: robert@fledge.watson.org
To: "Matthew N. Dodd" <mdodd@FreeBSD.ORG>
In-Reply-To: <20030402153711.U46852@sasami.jurai.net>
Message-ID: <Pine.NEB.3.96L.1030402163804.35655B-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-fs@FreeBSD.ORG
Subject: Re: setfstab()/getfstab()
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Apr 2003 21:38:00 -0000

On Wed, 2 Apr 2003, Matthew N. Dodd wrote:

> On Wed, 2 Apr 2003, Robert Watson wrote:
> > Hmm.  Maybe an issetugid() check before using the environmental variable?
> 
> Something like this? (whitespace damaged)

Yes, that looks reasonable to me.

> %%%
> @@ -226,7 +254,13 @@
>                 LineNo = 0;
>                 return(1);
>         }
> -       if ((_fs_fp = fopen(_PATH_FSTAB, "r")) != NULL) {
> +       if (fsp_set == 0) {
> +               if (issetugid())
> +                       setfstab(NULL);
> +               else
> +                       setfstab(getenv("PATH_FSTAB"));
> +       }
> +       if ((_fs_fp = fopen(path_fstab, "r")) != NULL) {
>                 LineNo = 0;
>                 return(1);
>         }
> %%%
> 
> 
> -- 
> | Matthew N. Dodd  | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD  |
> | winter@jurai.net |       2 x '84 Volvo 245DL        | ix86,sparc,pmax |
> | http://www.jurai.net/~winter |  For Great Justice!  | ISO8802.5 4ever |
>