From owner-freebsd-ports@FreeBSD.ORG Fri Sep 5 16:34:40 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B770BD92 for ; Fri, 5 Sep 2014 16:34:40 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 366881D7D for ; Fri, 5 Sep 2014 16:34:39 +0000 (UTC) Received: from mandree.no-ip.org ([78.49.247.146]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M5Lqx-1YK8Dj0dsl-00zWpc; Fri, 05 Sep 2014 18:21:32 +0200 Received: from [IPv6:::1] (localhost6.localdomain6 [IPv6:::1]) by apollo.emma.line.org (Postfix) with ESMTP id EC06E23CE71; Fri, 5 Sep 2014 18:21:30 +0200 (CEST) Message-ID: <5409E30A.7010808@gmx.de> Date: Fri, 05 Sep 2014 18:21:30 +0200 From: Matthias Andree User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: freebsd-ports@freebsd.org Subject: Re: First step (Re: [BRAINSTORMING] simplifying maintainer's life) References: <20140903082538.GE63085@ivaldir.etoilebsd.net> <20140905081911.GB25840@ivaldir.etoilebsd.net> In-Reply-To: <20140905081911.GB25840@ivaldir.etoilebsd.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:OZN3C3ulREgyt/VFOhxlo7mLJd4A/UH3tBVfT42o33hfcp+6aDf GB5Sl4xoWC5PHbaxV7moeaEqqy4RL7WQusuvwM54iGk6vJEtiF1K37HQh09A/HPTZ812xEq jDQIJ9p3hTi6vRDkwR8OhsHdCEgxCUoYGXCR6brBNegQA0Qy9WClNQjzqSb12ew+Hkp9L5d smqB57RNlBmbOZira6cZg== X-UI-Out-Filterresults: notjunk:1; Cc: Baptiste Daroussin X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2014 16:34:40 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 05.09.2014 um 10:19 schrieb Baptiste Daroussin: > After the discussion that happened here is what I think we should do > If no stong objections are raised thise this will happen in pkg 1.3.8 > > - Ignore mtree in packages > - Automatically handle directory removal for any directory under PREFIX > - Introduce @dir (in fact already there) for directories with special care: > * empty directories > * directories with special credential (@dir(user,group,mode)) > - Consider directories out of PREFIX as special hence needing to be listed with > @dir > > @dirrmtry and @dirrm will be considered changed into aliases for @dir but remain > for compatibility (with a warning if DEVELOPER_MODE is set) Is pkg now ready to reference-count multiple packages referencing the same directory? > > - the possibility to accept regular plist entry as directories will be in but > disable by default, allowing vendors to rely on it if they do want but leaving > the ports tree not accepting them (that clarifies a lot what the the plist for > maintainers) I strongly object to this part, and request that such dead code not be added to pkg. This is a gratuitious change, for "vendors" that as of now are phantoms (lack a particular use case), and, as written before, it voids error checking on the file type, and dead code is usually buggier than used code because noone sees the bugs until the code is enabled (but not properly reintegrated) years later. The use case why we need the distinction is the common error if a maintainer forgets the mkdir in the {pre,do,post}-install: target, and the install path lacks the trailing slash, then packaging will no longer fail. Example: post-install: ${INSTALL_DATA} blah/something ${STAGEDIR}${DOCSDIR}/blah This will rename something to blah while installing into ${DOCSDIR}, rather than installing "something" into ${DOCSDIR}/blah/. Especially with make makeplist or auto-plist rigs, this is bound to fail, and sit undiscovered for a while. If the distinction between directory and other file types remains explicit and mandatory, these errors are much harder to find. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlQJ4wIACgkQvmGDOQUufZU+ZwCggmcsS2yyo761R8X3a9xUHnm7 /yYAn0L3wvhqQYR21uTedLTco3sAXxvt =NJdy -----END PGP SIGNATURE-----