Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Mar 1996 09:12:37 +0000 ()
From:      "John S. Dyson" <toor@dyson.iquest.net>
To:        jkh@time.cdrom.com (Jordan K. Hubbard)
Cc:        dawes@rf900.physics.usyd.edu.au, sos@FreeBSD.org, dyson@FreeBSD.org, current@FreeBSD.org, mmead@Glock.COM
Subject:   Re: Try this vm_mmap.c -- please
Message-ID:  <199603160912.JAA04855@dyson.iquest.net>
In-Reply-To: <244.826979789@time.cdrom.com> from "Jordan K. Hubbard" at Mar 16, 96 04:36:29 am

next in thread | previous in thread | raw e-mail | index | archive | help
> 
> > Does accelx by any chance use MAP_PRIVATE?
> 
> Bingo!
> 
> Between David's comment here and John's own comment in the latest
> vm_mmap.c he sent out which says:
> 
> 	 * On device mmaps we default to map shared -- makes the most
> 	 * sense in this case.  Does MAP_PRIVATE even make sense on
> 	 * devices mmaps???
> 
> I made the following change:
> 
> 	if ((type == OBJT_DEVICE)) {
> 		if (flags & (MAP_PRIVATE|MAP_SHARED) == 0)
> 		    flags |= MAP_SHARED;
> 		else if (flags & MAP_PRIVATE)
> 		    flags &= ~MAP_PRIVATE;
> 	}
> 
I should be able to commit the "fix" early tonite (about 5:00 PM EST), if
someone else doesn't get to it before me.  Thanks everyone for helping
narrow this one down!!!

John




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199603160912.JAA04855>