From owner-freebsd-bugs@FreeBSD.ORG  Sun Nov  9 09:20:09 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DBEA316A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  9 Nov 2003 09:20:09 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 555A643FBF
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  9 Nov 2003 09:20:09 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hA9HK8FY088374
	for <freebsd-bugs@freefall.freebsd.org>;
	Sun, 9 Nov 2003 09:20:09 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hA9HK8LE088373;
	Sun, 9 Nov 2003 09:20:08 -0800 (PST)
	(envelope-from gnats)
Date: Sun, 9 Nov 2003 09:20:08 -0800 (PST)
Message-Id: <200311091720.hA9HK8LE088373@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Sergey Potapov <sp@ws.alkor.ru>
Subject: Re: kern/59062: nge0 swaps vlan tag bytes.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Sergey Potapov <sp@ws.alkor.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Nov 2003 17:20:10 -0000

The following reply was made to PR kern/59062; it has been noted by GNATS.

From: Sergey Potapov <sp@ws.alkor.ru>
To: freebsd-gnats-submit@FreeBSD.org, sp@alkor.ru
Cc:  
Subject: Re: kern/59062: nge0 swaps vlan tag bytes.
Date: Sun, 9 Nov 2003 20:13:52 +0300

 Addition.
 
 After applying simple path:
 =================================================================================
 --- if_nge.c.orig       Thu Feb  6 01:03:57 2003
 +++ if_nge.c    Sun Nov  9 18:41:27 2003
 @@ -1467,7 +1467,7 @@
                  * to vlan_input() instead of ether_input().
                  */
                 if (extsts & NGE_RXEXTSTS_VLANPKT) {
 -                       VLAN_INPUT_TAG(eh, m, extsts & NGE_RXEXTSTS_VTCI);
 +                       VLAN_INPUT_TAG(eh, m, ntohs(extsts & NGE_RXEXTSTS_VTCI));
                          continue;
                  }
 =================================================================================
 I've got the following results:
 
 1. I can see right vlan tag and vlan interface receives packets as
 desired.
 2. vlan inteface if configured as -link0 (software tag insertion in
 4.9-STABLE) sends vlan tag as desired, and if configured with link0
 sends something other.
 3. In any case packets with maximal MTU are'n send in right way,
 receiving is not tested.