From owner-svn-src-head@FreeBSD.ORG Thu Mar 26 21:59:13 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40950106566B; Thu, 26 Mar 2009 21:59:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id F42038FC0A; Thu, 26 Mar 2009 21:59:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 932F546B32; Thu, 26 Mar 2009 17:59:12 -0400 (EDT) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n2QLwkmT086524; Thu, 26 Mar 2009 17:59:06 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Doug Ambrisko Date: Thu, 26 Mar 2009 17:58:27 -0400 User-Agent: KMail/1.9.7 References: <200903262129.n2QLTgV9076134@ambrisko.com> In-Reply-To: <200903262129.n2QLTgV9076134@ambrisko.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903261758.28547.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 26 Mar 2009 17:59:06 -0400 (EDT) X-Virus-Scanned: ClamAV 0.94.2/9171/Thu Mar 26 13:49:28 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, Doug Ambrisko , Roman Divacky , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r190445 - in head/sys: amd64/linux32 compat/linprocfs compat/linux conf dev/ipmi modules/ipmi modules/linprocfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2009 21:59:13 -0000 On Thursday 26 March 2009 5:29:42 pm Doug Ambrisko wrote: > Roman Divacky writes: > | On Thu, Mar 26, 2009 at 05:14:23PM +0000, Doug Ambrisko wrote: > | > Author: ambrisko > | > Date: Thu Mar 26 17:14:22 2009 > | > New Revision: 190445 > | > URL: http://svn.freebsd.org/changeset/base/190445 > | > > | > Log: > | > Add stuff to support upcoming BMC/IPMI flashing of newer Dell machine > | > via the Linux tool. > | > - Add Linux shim to ipmi(4) > | > - Create a partitions file to linprocfs to make Linux fdisk see > | > disks. This file is dynamic so we can see disks come and go. > | > - Convert msdosfs to vfat in mtab since Linux uses that for > | > msdosfs. > | > - In the Linux mount path convert vfat passed in to msdosfs > | > so Linux mount works on FreeBSD. Note that tasting works > | > so that if da0 is a msdos file system > | > /compat/linux/bin/mount /dev/da0 /mnt > | > works. > | > - fix a 64it bug for l_off_t. > | > Grabing sh, mount, fdisk, df from Linux, creating a symlink of mtab to > | > /compat/linux/etc/mtab and then some careful unpacking of the Linux bmc > | > update tool and hacking makes it work on newer Dell boxes. Note, probably > | > if you can't figure out how to do this, then you probably shouldn't be > | > doing it :-) > | > > | > Added: > | > head/sys/dev/ipmi/ipmi_linux.c (contents, props changed) > | > Modified: > | > head/sys/amd64/linux32/linux.h > | > head/sys/compat/linprocfs/linprocfs.c > | > head/sys/compat/linux/linux_file.c > | > head/sys/conf/files.amd64 > | > head/sys/conf/files.i386 > | > head/sys/modules/ipmi/Makefile > | > head/sys/modules/linprocfs/Makefile > | > > | > Modified: head/sys/amd64/linux32/linux.h > | > ============================================================================== > | > --- head/sys/amd64/linux32/linux.h Thu Mar 26 17:04:08 2009 (r190444) > | > +++ head/sys/amd64/linux32/linux.h Thu Mar 26 17:14:22 2009 (r190445) > | > @@ -79,7 +79,7 @@ typedef l_ulong l_ino_t; > | > typedef l_int l_key_t; > | > typedef l_longlong l_loff_t; > | > typedef l_ushort l_mode_t; > | > -typedef l_long l_off_t; > | > +typedef l_ulong l_off_t; > | > | where did you get this idea? my copy of linux 2.6.16 shows that off_t > | is being declared as long. can you be more specific about the background > | of this change? what does it fix? > > Maybe you have another suggestion to fix this. The problem showed up > when doing a mmap of 0xcf79c000 into 0xffffffffcf79c000 also a mmap > of 0xf0000 ended up the same way. This caused it to fail. Note this > is only on amd64 with a Linux. It didn't happen with a FreeBSD i386 > version on amd64. Here is a sample test program: I'm sure this can be easily fixed in the Linux mmap() handlers instead. Do you know if your Linux binary is using mmap2() or the old mmap()? -- John Baldwin