From owner-freebsd-net@FreeBSD.ORG Mon Apr 5 16:54:25 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A67A91065672; Mon, 5 Apr 2010 16:54:25 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-fx0-f209.google.com (mail-fx0-f209.google.com [209.85.220.209]) by mx1.freebsd.org (Postfix) with ESMTP id CC8018FC0C; Mon, 5 Apr 2010 16:54:24 +0000 (UTC) Received: by fxm1 with SMTP id 1so2803623fxm.13 for ; Mon, 05 Apr 2010 09:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=Iw4BT0vbS3uIqdM+ueHF7IK1wyhPVbjFMRzD/o25HTU=; b=Ve4JQd6lwMepvVB7B1e04m1GWXzr2u1c0SO8pyVDu/+9X4gPPFNXpLoRXHDlbqC2Mx 21llpTWL9EaEquZhBfka1Rz3tQ6SkO9YBwiEds68i5mRfHbFmt95G2yVVE0qdVFui6ui Bkf0iXMnOMUJ7jlr+w0U+6RBxZ3Bzb3B46Ars= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=ObJXnGECVdHlsVLuO4HIimTCdRJIjAgRy++1kbFSdNWm1IYCS0SosGFmYuq+f6zGKH jABo4ZVolwoHiK2+Ed3LYan9zFkQd9vcbp4W0bkvPa+eankNyk+CXYMNbYggWHbfv/rH 37dXrp6YDwqdgPH/GOP6gA1FEycp/ZlEEBPBg= Received: by 10.223.117.164 with SMTP id r36mr6011340faq.28.1270486463779; Mon, 05 Apr 2010 09:54:23 -0700 (PDT) Received: from [10.0.10.2] (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by mx.google.com with ESMTPS id 13sm8046920fxm.10.2010.04.05.09.54.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 05 Apr 2010 09:54:22 -0700 (PDT) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: Date: Mon, 5 Apr 2010 17:54:20 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Rui Paulo X-Mailer: Apple Mail (2.1078) Cc: freebsd-net , Weongyo Jeong , Andrew Thompson , Bernhard Schmidt Subject: Re: net80211 ratectl proof of concept X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2010 16:54:25 -0000 On 31 Mar 2010, at 14:05, Rui Paulo wrote: > Hi, > I've started developing a ratectl framework for net80211, loosely = based on what DragonFly has. Right now only one driver has been ported, = but I would like your feedback before continuing. >=20 > The objective is to, eventually, have all the ratectl stuff (amrr, = sample, onoe(?) and rssadapt) in net80211 so all drivers can use it. We = can also select which ratectl modules are built in the kernel config = file. > The framework support changing the current ratectl is out of scope for = this patch. >=20 > You can find the patch here: > * http://people.freebsd.org/~rpaulo/ratectl.diff >=20 > Only the ral driver and the AMRR rate control algorithms were ported. >=20 > Some comments: > o The rate control calls now dereferences several pointers and some = inline functions are now real functions. I wonder how much this impacts = performance and what we can do to solve it. >=20 > o I wished there was a better way to do the IEEE80211_AMRR_SUCCESS / = IEEE80211_AMRR_FAILURe call. >=20 > o Some other stuff can also be `const' >=20 > o I create ieee80211_ratect.[ch] to avoid polluting other files >=20 > o I moved the AMRR parameters inside amrr_init() on purpose. The = drivers we have now only specify a different interval and I plan to add = export amrr_set_interval() via the ratectl framework later. >=20 >=20 > I would like very much to see this in, unless there's a strong = impending argument. I've ported all the drivers but I can't test them all. You can read the = patch at the same URL. I would like to commit this soon, though. Regards, -- Rui Paulo