Date: Thu, 27 May 2021 20:42:30 -0700 From: Neel Chauhan <nc@freebsd.org> To: koobs@freebsd.org Cc: ports-committers@freebsd.org, freebsd-ports@freebsd.org, portmgr@freebsd.org, gnome@freebsd.org, desktop@freebsd.org Subject: Re: An apology about my commits Message-ID: <8a8bf788f5deef5d83e9fcb5daa52f50@freebsd.org> In-Reply-To: <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org> References: <600673282f5cd5864a67655c4e156f26@freebsd.org> <303b9900-d008-78a7-b3bf-ffb33284a4ee@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> It's your thoughts and care that count Neel, don't feel guilty. Thanks! > The responses you received could have been a bit more 'matter of fact'. > > What was *actually* important about the replies was 'we should be > QA'ing everything and getting more than one persons eyes on things'. True, especially for big packages like GNOME, KDE, Mozilla, Xorg, or LibreOffice. Sometimes, I get trigger-happy. But I really shouldn't, well unless it's a hobby project on GitHub. > Note (for everyone), some of the biggest impacts are caused by the > smallest commits. > > The idea of a 'trivial update' needs to be related to the dustbin, and > we're still hearing it often. +1 I've had "trivial updates" that broke things, both in and outside FreeBSD. I've had code broken at my $DAYJOB, and that a Microsoft SaaS product (not a household name product like Windows or Word, but still). I was a major Tor contributor from 2017-2020 and had bad patches that broke things or add bugs get in, and that with Tor being very security-focused. And hey, it's not like I'm pulling a University of Minnesota "research project" where the goal is to intentionally add bugs to the Linux kernel. -Neel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8a8bf788f5deef5d83e9fcb5daa52f50>