From owner-freebsd-geom@FreeBSD.ORG  Wed May 19 09:20:16 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2548316A4CE; Wed, 19 May 2004 09:20:15 -0700 (PDT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6D7E243D2F; Wed, 19 May 2004 09:20:15 -0700 (PDT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 4FD33ACBCB; Wed, 19 May 2004 18:19:57 +0200 (CEST)
Date: Wed, 19 May 2004 18:19:57 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Message-ID: <20040519161957.GA845@darkness.comp.waw.pl>
References: <20040519165626.W4275@pcle2.cc.univie.ac.at>
	<20077.1084981408@critter.freebsd.dk>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="p+u7T7tYDgrfw07S"
Content-Disposition: inline
In-Reply-To: <20077.1084981408@critter.freebsd.dk>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: geom@freebsd.org
cc: Lukas Ertl <le@freebsd.org>
Subject: Re: Unloading GEOM classes
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2004 16:20:16 -0000


--p+u7T7tYDgrfw07S
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 19, 2004 at 05:43:28PM +0200, Poul-Henning Kamp wrote:
+> In message <20040519165626.W4275@pcle2.cc.univie.ac.at>, Lukas Ertl writ=
es:
+> >Hello fellow GEOM hackers,
+> >
+> >I'd like to get the discussion about unloading GEOM classes rolling aga=
in,
+> >and I'm really pleading for a change of the current code in geom_subr.c.
+>=20
+> OK, I just checked with peter@ and he belives that we can simply do
+> a DROP_GIANT() ... PICKUP_GIANT() in the g_modevent() and avoid the
+> need for the eventqueue there.
+>=20
+> Can somebody try that ?

Here is the patch:

	http://people.freebsd.org/~pjd/patches/g_unload_class.patch

UNTESTED. Lukas, could you try it and see if it fix your problem.
The whole trick could a g_waitidle() after calling destroy_geom method.

BTW. We should really commit g_waitidle_lock() version, it will be useful
here too:

	http://people.freebsd.org/~pjd/patches/g_waitidle_lock.patch

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--p+u7T7tYDgrfw07S
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAq4ktForvXbEpPzQRAtOEAJ9p2b/BhzLSkVVCfuHhB/u//t7R3gCePsna
kANDWhstw1OduLZ5LOhTmfI=
=R2rX
-----END PGP SIGNATURE-----

--p+u7T7tYDgrfw07S--