From owner-freebsd-current@FreeBSD.ORG Fri Aug 3 21:17:12 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D965106564A; Fri, 3 Aug 2012 21:17:12 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id CA9CF8FC15; Fri, 3 Aug 2012 21:17:11 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so2080180pbb.13 for ; Fri, 03 Aug 2012 14:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=AQEsojrmN4Juxmk3jh/S5Kpz2dp+l1LLHdJfJ991Z3w=; b=ia5c3Tp6aKICRK2rHuUDkf9d5edfWaZE58ynl8AzZScKEAoFPKvXrMwZX2G4k0S1eX 3/9a3dMtsrban0xZC3vJILjAWOiwg+NdBMjJRh+MWrVLeoVnXQZHRnVHWhDrpyCf17Bu JAJRMN9nU+JEOwGz2qSmLjsxj5d9SjOR5r92b7jKW0ifFXBiqveM2Fv5nne6nOPH4ThY PTJb23QBgCZ/FkgCTmCkMNKL1sz4yZx1jqA2QH5esrXk7Cq+mg53GVagITld991LrygJ ZWem1Ax+TLSEmdHekoGTdErG8ztDk5Ni7AMWowKsVSsiwVFp2zl1kR/dkyryB3rRwKnp sv8A== Received: by 10.68.227.201 with SMTP id sc9mr471426pbc.163.1344028631066; Fri, 03 Aug 2012 14:17:11 -0700 (PDT) Received: from fuji-wireless.local (c-24-19-191-56.hsd1.wa.comcast.net. [24.19.191.56]) by mx.google.com with ESMTPS id tq4sm186546pbc.11.2012.08.03.14.17.08 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Aug 2012 14:17:09 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <501C37D3.5040704@sentex.net> Date: Fri, 3 Aug 2012 14:17:09 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <9C0F7DB1-E75B-42A9-90A4-22599F99E15E@gmail.com> References: <201208031418.57941.jhb@freebsd.org> <201208031539.47735.jhb@freebsd.org> <501C37D3.5040704@sentex.net> To: Mike Tancsa X-Mailer: Apple Mail (2.1278) Cc: current@freebsd.org Subject: Re: [PATCH] Add locking to twe(4) so it no longer uses Giant X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2012 21:17:12 -0000 On Aug 3, 2012, at 1:42 PM, Mike Tancsa wrote: > On 8/3/2012 3:39 PM, John Baldwin wrote: >> On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote: >>> I'll try to find time to try it later today, but I'm in the middle = of >>> budget wrangling and I can't make any promises. >>>=20 >>> Before I try, will these patches apply to the twe driver in >>> 9.1-PRERELEASE? My system with twe was updated to RELENG_9 on July = 18. >>> I really don't have time to install current right now. >>=20 >> I believe the patches should apply fine on 8 and 9. If you use it on = 8 or 9 >> please make sure to enable INVARIANTS and INVARIANT_SUPPORT at least = for >> initial testing. Thanks! >=20 > Seems to apply to RELENG_9 just fine. Are there any stress tests you > suggest I run that might expose some bugs ? The machine is not > production yet, so its ok to crash it. Looking really quickly at the patch, it looks like most of the = locking changes are made around management pieces, and not data handling = pieces (but I might have missed something). If there's a tool for poking at the drives/controller, I would = use that, plus camcontrol. Of course you want a data intensive workload = (iometer/iozone/xdd with async and sync mode, random reads and = sequential reads, etc), and maybe resort to manual testing like pulling = drives (power, data) if you don't mind creating failures. If you have = some failed/failing drives kicking around, that would be a good test as = well (see that all/some of the failure paths are properly stimulated). Any variance or combining of these tests will help build = confidence in the change being proposed. HTH, -Garrett=