From owner-freebsd-stable@FreeBSD.ORG Sat Apr 11 08:36:26 2009 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 951C2106564A for ; Sat, 11 Apr 2009 08:36:26 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.187]) by mx1.freebsd.org (Postfix) with ESMTP id 2717B8FC12 for ; Sat, 11 Apr 2009 08:36:25 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by ti-out-0910.google.com with SMTP id u5so1320021tia.3 for ; Sat, 11 Apr 2009 01:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=5T2F7uTlxlnCW25h5REm762/Fc/PJZ8qlryDTM1xT8g=; b=pZ7/nAdFh7JDsBgP6Dnp32brzNnss5vnvRH3ksjnepjx57A1j9p5JSjefJk/U8qFPM +uYosraj8MnqDYWozYtOuqmzYkWzvhhIQ+SEXFZXTpCimPzbSPHLhsJpehoxuR1JXb0C XvdMul48ZvTX0p42TNYeXyt+u2rjNnBgRl/ow= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=gyZjmg/l2+RerxbQ+dk4Eo2G1F/gujqQF/ussRrkh4X4pI8JKR/KOFZPSUmyNs39pJ T4McAAN9VJwtOqckftc04rXbTkOEa9F2GvZIG7E+TwtggKWpGgKtAVAv81PnM4VSvgjW LkFpU/ejS6roNp7UDfFUN0tcBVwG7yJz53aLk= Received: by 10.110.69.5 with SMTP id r5mr2554502tia.19.1239438984920; Sat, 11 Apr 2009 01:36:24 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ([114.111.62.249]) by mx.google.com with ESMTPS id y5sm554600tia.17.2009.04.11.01.36.22 (version=SSLv3 cipher=RC4-MD5); Sat, 11 Apr 2009 01:36:23 -0700 (PDT) Received: by michelle.cdnetworks.co.kr (sSMTP sendmail emulation); Sat, 11 Apr 2009 17:37:59 +0900 From: Pyun YongHyeon Date: Sat, 11 Apr 2009 17:37:59 +0900 To: Beat Siegenthaler Message-ID: <20090411083759.GB54253@michelle.cdnetworks.co.kr> References: <49B1AC25.3000700@onetel.com> <27998819.871236382003017.JavaMail.HALO$@halo> <1d001f850903061814k2577f3ccs94be86bcc87b9efd@mail.gmail.com> <49B38AEF.8070909@beatsnet.com> <20090308093653.GD1531@michelle.cdnetworks.co.kr> <49B3FAA3.9010302@beatsnet.com> <20090309000610.GA5039@michelle.cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <20090309000610.GA5039@michelle.cdnetworks.co.kr> User-Agent: Mutt/1.4.2.3i Cc: stable@freebsd.org Subject: Re: fxp unusable after make world X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 08:36:26 -0000 --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 09, 2009 at 09:06:10AM +0900, Pyun YongHyeon wrote: > On Sun, Mar 08, 2009 at 06:04:35PM +0100, Beat Siegenthaler wrote: > > Pyun YongHyeon wrote: > > > > > > > > I touched fxp(4) to add more hardware assistance so it could cause > > > problems on your box. Please show me dmesg output and > > > "ifconfig fxp0" > > > output. > > > > > > If you doubt checksum offloading or TSO issues, try > > > "ifconfig fxp0 -tso -txcsum -rxcsum". > > > > > And the command above fixed your issue? > It seems that fxp(4) has a TSO bug. Would you try attached patch? (Make sure to enable TSO to check whether the issue was resolved.) --s2ZSL+KKDSLx8OML Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="fxp.tso.patch" Index: sys/dev/fxp/if_fxp.c =================================================================== --- sys/dev/fxp/if_fxp.c (revision 190876) +++ sys/dev/fxp/if_fxp.c (working copy) @@ -1485,7 +1485,8 @@ * checksum in the first frame driver should compute it. */ ip->ip_sum = 0; - ip->ip_len = htons(ifp->if_mtu); + ip->ip_len = htons(m->m_pkthdr.tso_segsz + (ip->ip_hl << 2) + + (tcp->th_off << 2)); tcp->th_sum = in_pseudo(ip->ip_src.s_addr, ip->ip_dst.s_addr, htons(IPPROTO_TCP + (tcp->th_off << 2) + m->m_pkthdr.tso_segsz)); --s2ZSL+KKDSLx8OML--