From owner-freebsd-audit Mon Nov 26 14:56: 5 2001 Delivered-To: freebsd-audit@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 29CF737B405; Mon, 26 Nov 2001 14:56:01 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id fAQMtwo54268; Mon, 26 Nov 2001 22:55:58 GMT (envelope-from mark@grondar.za) Received: from grondar.za (mark@localhost [127.0.0.1]) by grimreaper.grondar.org (8.11.6/8.11.6) with ESMTP id fAQLgWF01871; Mon, 26 Nov 2001 21:42:32 GMT (envelope-from mark@grondar.za) Message-Id: <200111262142.fAQLgWF01871@grimreaper.grondar.org> To: Dag-Erling Smorgrav Cc: audit@freebsd.org, markm@freebsd.org Subject: Re: PAM module patch for review References: In-Reply-To: ; from Dag-Erling Smorgrav "26 Nov 2001 17:44:46 +0100." Date: Mon, 26 Nov 2001 21:42:32 +0000 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > Attached. Not as much as I'd like - I did absolutely zip on PAM last > week - but better than nothing, and I'll try to pick up the pace a > bit. > > Summary of changes: > > - Dummy facilities as previously discussed; they all return > PAM_IGNORE, which is possibly wrong for at least some of them, but > I'll take a closer look at each of them and tweak them later as I > gain more experience with PAM. Ok - good first srat, but I'm not keen to see this committed until all of the effects are at least understood. I'll read documentation and play so i can contruibute here. > - New pam_self(8) module with man page. Cool! :-) > - New pam_ssh(8) man page. Cool^2! > - Ndditions to the pam_unix(8) man page. Cool^3! > - Some minor style(9) fixes. I personally disagree with - } - else { + } else { as these get too caught up in other diffs. stuff { : } else { : } Separates the blocks out better. The others don't seem too bad. > I'm going to continue cleaning up the module man pages and tweak the > dummy facilities a bit. Yes please! M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message