From owner-freebsd-net@freebsd.org Tue Mar 23 18:31:35 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B7E75B7A7E for ; Tue, 23 Mar 2021 18:31:35 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4g1g0t9lz3lQq; Tue, 23 Mar 2021 18:31:34 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2a02:8109:1140:c3d:3063:f2ec:8e4c:4b] (unknown [IPv6:2a02:8109:1140:c3d:3063:f2ec:8e4c:4b]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 393D67229E452; Tue, 23 Mar 2021 19:31:32 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: tcp-testsuite into src? From: tuexen@freebsd.org In-Reply-To: Date: Tue, 23 Mar 2021 19:31:31 +0100 Cc: Kevin Bowling , FreeBSD Net , rscheff@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <47E051ED-62D6-4032-8F33-A322F45D93ED@freebsd.org> References: To: Alan Somers X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4F4g1g0t9lz3lQq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 18:31:35 -0000 > On 23. Mar 2021, at 03:45, Alan Somers wrote: >=20 > On Mon, Mar 22, 2021 at 7:31 PM Kevin Bowling = wrote: > Hi, >=20 > I was talking with gnn and kevans on IRC about the tcp testsuite > (https://github.com/freebsd-net/tcp-testsuite). >=20 > Currently we maintain this in ports, although the way the port is set > up doesn't make a lot of sense because the tests are stack specific > and we don't account for different FreeBSD versions let alone vendor > trees. It seems reasonable to me to pull the tests themselves (i.e. > https://github.com/freebsd-net/tcp-testsuite) into src where they can > follow along with the tree they are running on, and provide vendors a > natural point of extension. >=20 > /usr/tests has some existing examples of relying on out of tree > binaries to run so I am not convinced we need to import packetdrill > itself but I don't have a strong preference. tuexen, do you have any > preference? >=20 > Regards, > Kevin > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >=20 > Yeah, it's not a problem to use binaries from ports in /usr/tests. As = long as the tests can=20 > compile they can live in the base system. Is there a strong incentive = to import them? Do=20 The tests are just scripts, which can be executed by packetdrill, which = is available in the ports tree. > they need to be adjusted for each release?=20 It depends. If things like default timeouts or so change, then the tests = need to be adapted. If we would have (and I guess we will) tests for loss recovery, then = improvements to the code might also require changes to the tests. Best regards Michael