From owner-freebsd-stable Fri Jan 5 15:52: 3 2001 From owner-freebsd-stable@FreeBSD.ORG Fri Jan 5 15:51:59 2001 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 7FF3737B400 for ; Fri, 5 Jan 2001 15:51:58 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 24C306A90D; Sat, 6 Jan 2001 10:21:57 +1030 (CST) Date: Sat, 6 Jan 2001 10:21:57 +1030 From: Greg Lehey To: Brad Knowles Cc: Tor.Egge@fast.no, andy.depetter@ops.skynet.be, freebsd-stable@FreeBSD.ORG Subject: Re: Problems with corrupted vinum devices... Message-ID: <20010106102157.B48589@wantadilla.lemis.com> References: <200101051644.RAA17887@midten.fast.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from blk@skynet.be on Fri, Jan 05, 2001 at 06:39:02PM +0100 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Friday, 5 January 2001 at 18:39:02 +0100, Brad Knowles wrote: > At 5:44 PM +0100 2001/1/5, Tor.Egge@fast.no wrote: > >> diff -ru /tmp/vinum/vinumvar.h ./vinumvar.h >> --- /tmp/vinum/vinumvar.h Mon May 22 18:21:37 2000 >> +++ ./vinumvar.h Thu Jan 4 19:12:01 2001 > Let's look again at the full comment block before this segment of code: > >> /* >> * the number of object entries to cater for initially, and also the >> * value by which they are incremented. It doesn't take long >> * to extend them, so theoretically we could start with 1 of each, but >> * it's untidy to allocate such small areas. These values are >> * probably too small. >> */ > > Theoretically, changing the initial values should have no impact > whatsoever on the ability (or lack thereof) to create devices, so > long as you're not exceeding the specified maximums. Vinum should > automatically extend the necessary data structures beyond these > initial defaults, if the need should arise. If vinum isn't doing > this, then the code to do those extensions is faulty and it should be > fixed instead. Correct. It's broken, and Tor's patch is a workaround. > The more I think about this, the less I think that this has > anything at all to do with either the problems you experienced, or > the problems we're having. I'm quite sure they're related to the problems Tor has been experiencing. But, as I've said, they're different. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message