From owner-svn-src-head@freebsd.org Thu Jun 20 15:14:02 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A44615BEB7D for ; Thu, 20 Jun 2019 15:14:02 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E845857B3 for ; Thu, 20 Jun 2019 15:14:01 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1561043637; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=gv+fiebKEuO8F/pX1kC296hOLSNJ22YrF49ZMni48a757+mx7Pa9qszDyd+3nX2hyex37M5tTVCmj DqB060l+5U49qP8v7qg9RgEDAbDUWv1BzWTU9NGj+X5v2aYN0JWeITiZYhte5q4oZS5Viijx9eT9HD kS8cAGuQvKbn13GqeZeMd596zo0fHyVBIx/GtPyiFFnP2auiyQy7m2RXZZSB3ocMxiAKTyunWxGmyC bdEBJBD0CY2+X8/FMDkPXS0Tt1r/t9d7gV0xi0dJguCA/2EQnu4vnsPuBXRRVk1vSfrZFBXgEbwi4Y XNd8yJNHClXFoGcstIYT0Ykroi45d/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=EkGHYOWkrZ/tH/Q1s8zxh+mEMrI7CC5EjUOheh5ixss=; b=PFKoV/iKlj9yN76YpISJgBKG76KUtP0whZIr6Rxz0/4iyfiOjg5b4tGeZTzBmCknhEzFMFQ1OdGM9 SL9aP6NacB9W6sw3JC3Wq7nqV4MJhJWoEjQsavjjMQzmOF3IFZtHUz3QoINs2HmzUN0F9DWKplMZlk nMAK0LFqL7j8W4mk6ungmHGFlU7IlmmQmoTNh4siwWt0Hi40V/c8RnDSt6sNr7T+WDY7zzytFr/OA9 +RdQ9syJW1oOKJ0NrnPv9/NNk8E7DNxB2gXDtmnoXxY77LCtXq9SipiZrMlYDlQGvcEzXbUO3SOv39 CsN7VOEOXSP1an0dB7QjBtMPvYinA3Q== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=EkGHYOWkrZ/tH/Q1s8zxh+mEMrI7CC5EjUOheh5ixss=; b=HiTYjERDdlZ5TBBER/iCOGYFrRZW+6b1HlfAjSEDwieq0t2/qk3c4e/8t4sSObYtqGI/qxn2VmRyU UoSuvz7Ob+OiBaXFw+tKlyIKQp1RJFsoX6LUFk1oxrBh06CZBQbwvCuVyywylmcIGW8thfKaCMYrVs Xoz5pvEKAcin7+Z5/9KaNKbILzBfozPM0z9bKPPp71VBI3hUxTuKSsqJeF+PvekC8GZwN6pDBLkd8V yRspOPRqoHb8Bgs8XvSxCpBrTV87rGnC/YnyLTocUHAI1rqMspCCcFfqgoWyT1nUWK/PXeaiA568t/ kbucfSqbmiQMvALq8Vi11V3ujw9VMBw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 03ddf159-936e-11e9-b1d6-935efd94926c X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id 03ddf159-936e-11e9-b1d6-935efd94926c; Thu, 20 Jun 2019 15:13:54 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x5KFDqfG026447; Thu, 20 Jun 2019 09:13:52 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <54f3bc97cbb485cdcc44b81c82c149ac9e46d42f.camel@freebsd.org> Subject: Re: svn commit: r349233 - head/sys/sys From: Ian Lepore To: Alan Somers , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 20 Jun 2019 09:13:52 -0600 In-Reply-To: <201906201435.x5KEZTqH021513@repo.freebsd.org> References: <201906201435.x5KEZTqH021513@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6E845857B3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.995,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 15:14:02 -0000 On Thu, 2019-06-20 at 14:35 +0000, Alan Somers wrote: > Author: asomers > Date: Thu Jun 20 14:35:28 2019 > New Revision: 349233 > URL: https://svnweb.freebsd.org/changeset/base/349233 > > Log: > #include from sys/filio.h > > This fixes world build after r349231 > > Reported by: Jenkins > MFC after: 2 weeks > MFC-With: 349231 > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/sys/filio.h > > Modified: head/sys/sys/filio.h > ===================================================================== > ========= > --- head/sys/sys/filio.h Thu Jun 20 14:34:45 2019 (r349232) > +++ head/sys/sys/filio.h Thu Jun 20 14:35:28 2019 (r349233) > @@ -40,6 +40,7 @@ > #ifndef _SYS_FILIO_H_ > #define _SYS_FILIO_H_ > > +#include > #include > > /* Generic file-descriptor ioctl's. */ > I wonder... is this one of those situations where it is better to use __int64_t in the struct, then #include ? I think the net effect there would be less pollution with other types? I've never seen written guidance about when to use the __names and _types.h, but I've always had the general impression that if you have to include a header from another system header, it's better to use the _header.h if it exists. -- Ian